Re: [PATCH] tools/libs/stat: fix broken build

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 11/09/2020 18:58, Wei Liu wrote:
> On Fri, Sep 11, 2020 at 03:15:28PM +0200, Juergen Gross wrote:
>> Making getBridge() static triggered a build error with some gcc versions:
>>
>> error: 'strncpy' output may be truncated copying 15 bytes from a string of
>> length 255 [-Werror=stringop-truncation]
>>
>> Fix that by printing a sane error message and bailing out in case the name of
>> a bridge is too long.
>>
>> Fixes: 6d0ec053907794 ("tools: split libxenstat into new tools/libs/stat 
>> directory")
> But this patch is not the one that created the bug though? It just
> happens to be the last patch that touched that file.

It "created" the bug by making getBridge() static, and therefore inlined
into its sole caller, and therefore able to be analysed in this way by
the compiler.

That said, Gitlab CI says no to this as a viable bugfix.

~Andrew