[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 20/21] drm/xlnx: Initialize DRM driver instance with CMA helper macro



Hi Thomas,

Thank you for the patch.

On Tue, Sep 15, 2020 at 04:59:57PM +0200, Thomas Zimmermann wrote:
> The xlnx driver uses CMA helpers with default callback functions.
> Initialize the driver structure with the rsp CMA helper macro. The
> driver is being converted to use GEM object functions as part of
> this change.
> 
> Two callbacks, .dumb_destroy and .gem_prime_import, were initialized
> to their default implementations, so they are just kept empty now.
> 
> v2:
>       * initialize with DRM_GEM_CMA_DRIVER_OPS_WITH_DUMB_CREATE (Laurent)
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>

Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

> ---
>  drivers/gpu/drm/xlnx/zynqmp_dpsub.c | 14 +-------------
>  1 file changed, 1 insertion(+), 13 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c 
> b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
> index 8e69303aad3f..f3ffc3703a0e 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_dpsub.c
> @@ -80,19 +80,7 @@ static struct drm_driver zynqmp_dpsub_drm_driver = {
>       .driver_features                = DRIVER_MODESET | DRIVER_GEM |
>                                         DRIVER_ATOMIC,
>  
> -     .prime_handle_to_fd             = drm_gem_prime_handle_to_fd,
> -     .prime_fd_to_handle             = drm_gem_prime_fd_to_handle,
> -     .gem_prime_export               = drm_gem_prime_export,
> -     .gem_prime_import               = drm_gem_prime_import,
> -     .gem_prime_get_sg_table         = drm_gem_cma_prime_get_sg_table,
> -     .gem_prime_import_sg_table      = drm_gem_cma_prime_import_sg_table,
> -     .gem_prime_vmap                 = drm_gem_cma_prime_vmap,
> -     .gem_prime_vunmap               = drm_gem_cma_prime_vunmap,
> -     .gem_prime_mmap                 = drm_gem_cma_prime_mmap,
> -     .gem_free_object_unlocked       = drm_gem_cma_free_object,
> -     .gem_vm_ops                     = &drm_gem_cma_vm_ops,
> -     .dumb_create                    = zynqmp_dpsub_dumb_create,
> -     .dumb_destroy                   = drm_gem_dumb_destroy,
> +     DRM_GEM_CMA_DRIVER_OPS_WITH_DUMB_CREATE(zynqmp_dpsub_dumb_create),
>  
>       .fops                           = &zynqmp_dpsub_drm_fops,
>  

-- 
Regards,

Laurent Pinchart



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.