[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] x86/mm: Simplify expression in set_gpfn_from_mfn()


  • To: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Tue, 15 Sep 2020 18:53:55 +0100
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Tue, 15 Sep 2020 17:54:48 +0000
  • Ironport-sdr: puOSgV0rpfkqzd0vZVPnNk79HLXGm5UGSYps9mX2ER5YWeQwtd4XP+QhIPTJQqBrQrZ4Me0ga9 C6h9xwVopDzcfdF6+ujzoSf0YTaXoGlIX+1vohrtO/S0LpWpOqYaUmTfz7MeJVhznjmCphFvz2 ku6mHy8DMGN2jtQ9PlTFoX2QYMBlsTXiuvbz1dCdSYpvBWw2RZ2/uwQdzz79ZbFOwJicFJi2r9 97k2i766C23T8f97yvrHdYJt0NabQMm8Hcm5c8VfSvOJZw8g1U1DpllATxUpgILpbql8wsKOtK rYE=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Coverity points out that the "d &&" is redundant.

Fixes: c9476c4ad72 ("x86: don't override INVALID_M2P_ENTRY with 
SHARED_M2P_ENTRY")
Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
---
CC: Jan Beulich <JBeulich@xxxxxxxx>
CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
CC: Wei Liu <wl@xxxxxxx>
---
 xen/arch/x86/x86_64/mm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/x86/x86_64/mm.c b/xen/arch/x86/x86_64/mm.c
index 0d1aadbfce..4c0a3a275c 100644
--- a/xen/arch/x86/x86_64/mm.c
+++ b/xen/arch/x86/x86_64/mm.c
@@ -1336,7 +1336,7 @@ void set_gpfn_from_mfn(unsigned long mfn, unsigned long 
pfn)
     {
         const struct domain *d = page_get_owner(mfn_to_page(_mfn(mfn)));
 
-        if ( d && (d == dom_cow) )
+        if ( d == dom_cow )
             entry = SHARED_M2P_ENTRY;
     }
 
-- 
2.11.0




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.