Re: Compiling Xen from source

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 15/09/2020 21:16, David I wrote:
> Hello,
>
> I am unable to mcompile xen-tools from source.
>
> here is the "stacktrace":
>
> ln -f xenstore xenstore-watch
> gcc xenstore_control.o    
>  -Wl,-rpath-link=/home/david/xen/xen/tools/xenstore/../../tools/libs/toolcore
> /home/david/xen/xen/tools/xenstore/../../tools/xenstore/libxenstore.so
> -ldl
>  
> /home/david/xen/xen/tools/xenstore/../../tools/libs/toolcore/libxentoolcore.so
>  -o xenstore-control
> gcc  -m64 -DBUILD_ID -fno-strict-aliasing -std=gnu99 -Wall
> -Wstrict-prototypes -Wdeclaration-after-statement
> -Wno-unused-but-set-variable -Wno-unused-local-typedefs   -O2
> -fomit-frame-pointer
> -D__XEN_INTERFACE_VERSION__=__XEN_LATEST_INTERFACE_VERSION__ -MMD -MF
> .xs_tdb_dump.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE   -Werror
> -I. -include /home/david/xen/xen/tools/xenstore/../../tools/config.h
> -I./include
> -I/home/david/xen/xen/tools/xenstore/../../tools/libs/evtchn/include
> -I/home/david/xen/xen/tools/xenstore/../../tools/include
> -I/home/david/xen/xen/tools/xenstore/../../tools/libxc/include
> -I/home/david/xen/xen/tools/xenstore/../../tools/libs/toollog/include
> -I/home/david/xen/xen/tools/xenstore/../../tools/include
> -I/home/david/xen/xen/tools/xenstore/../../tools/libs/foreignmemory/include
> -I/home/david/xen/xen/tools/xenstore/../../tools/include
> -I/home/david/xen/xen/tools/xenstore/../../tools/libs/devicemodel/include
> -I/home/david/xen/xen/tools/xenstore/../../tools/include
> -I/home/david/xen/xen/tools/xenstore/../../tools/include
> -D__XEN_TOOLS__
> -I/home/david/xen/xen/tools/xenstore/../../tools/libs/toolcore/include
> -I/home/david/xen/xen/tools/xenstore/../../tools/include
> -DXEN_LIB_STORED="\"/var/lib/xenstored\""
> -DXEN_RUN_STORED="\"/var/run/xenstored\""   -c -o xs_tdb_dump.o
> xs_tdb_dump.c
> gcc  -m64 -DBUILD_ID -fno-strict-aliasing -std=gnu99 -Wall
> -Wstrict-prototypes -Wdeclaration-after-statement
> -Wno-unused-but-set-variable -Wno-unused-local-typedefs   -O2
> -fomit-frame-pointer
> -D__XEN_INTERFACE_VERSION__=__XEN_LATEST_INTERFACE_VERSION__ -MMD -MF
> .utils.o.d -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE   -Werror -I.
> -include /home/david/xen/xen/tools/xenstore/../../tools/config.h
> -I./include
> -I/home/david/xen/xen/tools/xenstore/../../tools/libs/evtchn/include
> -I/home/david/xen/xen/tools/xenstore/../../tools/include
> -I/home/david/xen/xen/tools/xenstore/../../tools/libxc/include
> -I/home/david/xen/xen/tools/xenstore/../../tools/libs/toollog/include
> -I/home/david/xen/xen/tools/xenstore/../../tools/include
> -I/home/david/xen/xen/tools/xenstore/../../tools/libs/foreignmemory/include
> -I/home/david/xen/xen/tools/xenstore/../../tools/include
> -I/home/david/xen/xen/tools/xenstore/../../tools/libs/devicemodel/include
> -I/home/david/xen/xen/tools/xenstore/../../tools/include
> -I/home/david/xen/xen/tools/xenstore/../../tools/include
> -D__XEN_TOOLS__
> -I/home/david/xen/xen/tools/xenstore/../../tools/libs/toolcore/include
> -I/home/david/xen/xen/tools/xenstore/../../tools/include
> -DXEN_LIB_STORED="\"/var/lib/xenstored\""
> -DXEN_RUN_STORED="\"/var/run/xenstored\""  
> -I/home/david/xen/xen/tools/xenstore/../../tools/libs/gnttab/include
> -I/home/david/xen/xen/tools/xenstore/../../tools/include  -c -o
> utils.o utils.c
> gcc xs_tdb_dump.o utils.o tdb.o talloc.o     -o xs_tdb_dump
> /usr/bin/ld : utils.o:(.data.rel.local+0x0) : définitions multiples de
> « xprintf »; xs_tdb_dump.o:(.bss+0x0) : défini pour la première fois ici
> collect2: error: ld returned 1 exit status
> make[4]: *** [Makefile:97 : xs_tdb_dump] Erreur 1
> make[4] : on quitte le répertoire « /home/david/xen/xen/tools/xenstore »
> make[3]: *** [/home/david/xen/xen/tools/../tools/Rules.mk:249 :
> subdir-install-xenstore] Erreur 2
> make[3] : on quitte le répertoire « /home/david/xen/xen/tools »
> make[2]: *** [/home/david/xen/xen/tools/../tools/Rules.mk:244 :
> subdirs-install] Erreur 2
> make[2] : on quitte le répertoire « /home/david/xen/xen/tools »
> make[1]: *** [Makefile:74 : install] Erreur 2
> make[1] : on quitte le répertoire « /home/david/xen/xen/tools »
> make: *** [Makefile:127 : install-tools] Erreur 2
> david@debian:~/xen/xen$ uname -a
> Linux debian 5.7.0-2-amd64 #1 SMP Debian 5.7.10-1 (2020-07-26) x86_64
> GNU/Linux
> david@debian:~/xen/xen$ gcc --version
> gcc (Debian 10.2.0-5) 10.2.0
> Copyright (C) 2020 Free Software Foundation, Inc.
> This is free software; see the source for copying conditions.  There is NO
> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR
> PURPOSE.
>
> david@debian:~/xen/xen$ /usr/bin/ld --version
> GNU ld (GNU Binutils for Debian) 2.35
> Copyright (C) 2020 Free Software Foundation, Inc.
> Ce logiciel est libre; si vous le redistribuez, vous devez le faire
> selon les termes
> de la licence GNU General Public License version 3 ou postérieure
> selon votre besoin.
> Ce logiciel n'est couvert par aucune GARANTIE.
> david@debian:~/xen/xen$ git branch
>   master
> * stable-4.11
>   staging
> david@debian:~/xen/xen$
>
> I was able to compile dist-xen correctly though. But dist-tools fails
> with this error, I have seen a similar request here:
> https://stackoverflow.com/questions/63525163/usr-bin-ld-utils-o-data-rel-local0x0-multiple-definition-of-xprintf-xs
>
> I have tried to compile xen from source also on this same configuration,
> in stable-4.12, stable-4.13, stable-4.14, each time I was able to 
> compile xen but failed to compile xen-tools.
> the debian package works fine and is in version 4.11.
>
> So my question would be, is there a patch for this issue ? and how the
> debian team could compile originally the debian source package ? I
> suppose I am not the first user to encounter this.
>
> Thank you for your answers ;-)

Its a change in the toolchain from -fcommon to -fno-common by default.

Already fixed upstream by: 
https://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=dacdbf7088d6a3705a9831e73991c2b14c519a65

Looks like that change wants backporting.

~Andrew