RE: [PATCH 3/5] qom: Remove module_obj_name parameter from OBJECT_DECLARE* macros

[Paul Durrant <xadimgnik@xxxxxxxxx>]

> -----Original Message-----
> From: Eduardo Habkost <ehabkost@xxxxxxxxxx>
> Sent: 16 September 2020 19:25
> To: qemu-devel@xxxxxxxxxx
> Cc: Paolo Bonzini <pbonzini@xxxxxxxxxx>; Daniel P. Berrange 
> <berrange@xxxxxxxxxx>; Marc-André Lureau
> <marcandre.lureau@xxxxxxxxxx>; Gerd Hoffmann <kraxel@xxxxxxxxxx>; Michael S. 
> Tsirkin <mst@xxxxxxxxxx>;
> Peter Maydell <peter.maydell@xxxxxxxxxx>; Corey Minyard 
> <cminyard@xxxxxxxxxx>; Cédric Le Goater
> <clg@xxxxxxxx>; David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>; Cornelia Huck 
> <cohuck@xxxxxxxxxx>; Thomas
> Huth <thuth@xxxxxxxxxx>; Halil Pasic <pasic@xxxxxxxxxxxxx>; Christian 
> Borntraeger
> <borntraeger@xxxxxxxxxx>; Philippe Mathieu-Daudé <f4bug@xxxxxxxxx>; Alistair 
> Francis
> <alistair@xxxxxxxxxxxxx>; David Hildenbrand <david@xxxxxxxxxx>; Laurent 
> Vivier <lvivier@xxxxxxxxxx>;
> Amit Shah <amit@xxxxxxxxxx>; Stefano Stabellini <sstabellini@xxxxxxxxxx>; 
> Anthony Perard
> <anthony.perard@xxxxxxxxxx>; Paul Durrant <paul@xxxxxxx>; Fam Zheng 
> <fam@xxxxxxxxxx>; Gonglei (Arei)
> <arei.gonglei@xxxxxxxxxx>; Igor Mammedov <imammedo@xxxxxxxxxx>; Stefan Berger 
> <stefanb@xxxxxxxxxxxxx>;
> Richard Henderson <rth@xxxxxxxxxxx>; Michael Rolnik <mrolnik@xxxxxxxxx>; 
> Sarah Harris
> <S.E.Harris@xxxxxxxxxx>; Edgar E. Iglesias <edgar.iglesias@xxxxxxxxx>; 
> Michael Walle
> <michael@xxxxxxxx>; Aleksandar Markovic <aleksandar.qemu.devel@xxxxxxxxx>; 
> Aurelien Jarno
> <aurelien@xxxxxxxxxxx>; Jiaxun Yang <jiaxun.yang@xxxxxxxxxxx>; Aleksandar 
> Rikalo
> <aleksandar.rikalo@xxxxxxxxxx>; Anthony Green <green@xxxxxxxxxxxxxx>; Chris 
> Wulff <crwulff@xxxxxxxxx>;
> Marek Vasut <marex@xxxxxxx>; Stafford Horne <shorne@xxxxxxxxx>; Palmer 
> Dabbelt <palmer@xxxxxxxxxxx>;
> Sagar Karandikar <sagark@xxxxxxxxxxxxxxxxx>; Bastian Koppelmann 
> <kbastian@xxxxxxxxxxxxxxxxxxxxx>;
> Yoshinori Sato <ysato@xxxxxxxxxxxxxxxxxxxx>; Mark Cave-Ayland 
> <mark.cave-ayland@xxxxxxxxxxxx>; Artyom
> Tarasenko <atar4qemu@xxxxxxxxx>; Guan Xuetao <gxt@xxxxxxxxxxxxxxx>; Max 
> Filippov <jcmvbkbc@xxxxxxxxx>;
> qemu-arm@xxxxxxxxxx; qemu-ppc@xxxxxxxxxx; qemu-s390x@xxxxxxxxxx; 
> qemu-block@xxxxxxxxxx; xen-
> devel@xxxxxxxxxxxxxxxxxxxx; qemu-riscv@xxxxxxxxxx
> Subject: [PATCH 3/5] qom: Remove module_obj_name parameter from 
> OBJECT_DECLARE* macros
> 
> One of the goals of having less boilerplate on QOM declarations
> is to avoid human error.  Requiring an extra argument that is
> never used is an opportunity for mistakes.
> 
> Remove the unused argument from OBJECT_DECLARE_TYPE and
> OBJECT_DECLARE_SIMPLE_TYPE.
> 
> Coccinelle patch used to convert all users of the macros:
> 
>   @@
>   declarer name OBJECT_DECLARE_TYPE;
>   identifier InstanceType, ClassType, lowercase, UPPERCASE;
>   @@
>    OBJECT_DECLARE_TYPE(InstanceType, ClassType,
>   -                    lowercase,
>                        UPPERCASE);
> 
>   @@
>   declarer name OBJECT_DECLARE_SIMPLE_TYPE;
>   identifier InstanceType, lowercase, UPPERCASE;
>   @@
>    OBJECT_DECLARE_SIMPLE_TYPE(InstanceType,
>   -                    lowercase,
>                        UPPERCASE);
> 
> Signed-off-by: Eduardo Habkost <ehabkost@xxxxxxxxxx>

Acked-by: Paul Durrant <paul@xxxxxxx>