Re: [PATCH v5 3/5] efi/boot.c: add handle_file_info()

[Jan Beulich <jbeulich@xxxxxxxx>]

On 17.09.2020 17:40, Trammell Hudson wrote:
> Add a separate function to display the address ranges used by
> the files and call `efi_arch_handle_module()` on the modules.
> 
> Signed-off-by: Trammell Hudson <hudson@xxxxxxxx>

You've lost the ack I gave, and ...

> --- a/xen/common/efi/boot.c
> +++ b/xen/common/efi/boot.c
> @@ -540,6 +540,22 @@ static char * __init split_string(char *s)
>      return NULL;
>  }
>  
> +static void __init handle_file_info(CHAR16 *name,
> +                                    const struct file *file, const char 
> *options)

... with the const added here you ought to mention (in a post-
description remark perhaps) that this now depends on a not yet
applied patch on the list). Remember that reviewers and
committer may be different people, and even if the committer
participated in review, (s)he may have forgotten by the time
a patch is otherwise ready to go in.

And btw - briefly mentioning what changes you made compared to
the previous version (again in a post-description remark) helps
reviews quite a bit.

Jan