Re: [PATCH] common/Kconfig: sort HAS_*

[Julien Grall <julien@xxxxxxx>]

Hi Jan,

On 22/09/2020 08:47, Jan Beulich wrote:
> Later additions look to have been put at the end, with MEM_ACCESS*
> somewhere in the middle. Re-sort this part of the file, in the hope that
> future additions will be made noticing the intentions here.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

> --- a/xen/common/Kconfig
> +++ b/xen/common/Kconfig
> @@ -34,16 +34,11 @@ config HAS_EX_TABLE
>   config HAS_FAST_MULTIPLY
>         bool
>   
> -config MEM_ACCESS_ALWAYS_ON
> +config HAS_IOPORTS
>         bool
>   
> -config MEM_ACCESS
> -       def_bool MEM_ACCESS_ALWAYS_ON
> -       prompt "Memory Access and VM events" if !MEM_ACCESS_ALWAYS_ON
> -       ---help---
> -
> -         Framework to configure memory access types for guests and receive
> -         related events in userspace.
> +config HAS_KEXEC
> +       bool
>   
>   config HAS_MEM_PAGING
>         bool
> @@ -51,17 +46,22 @@ config HAS_MEM_PAGING
>   config HAS_PDX
>         bool
>   
> -config HAS_UBSAN
> +config HAS_SCHED_GRANULARITY
>         bool
>   
> -config HAS_KEXEC
> +config HAS_UBSAN
>         bool
>   
> -config HAS_IOPORTS
> +config MEM_ACCESS_ALWAYS_ON
>         bool
>   
> -config HAS_SCHED_GRANULARITY
> -       bool
> +config MEM_ACCESS
> +       def_bool MEM_ACCESS_ALWAYS_ON
> +       prompt "Memory Access and VM events" if !MEM_ACCESS_ALWAYS_ON
> +       ---help---
> +
> +         Framework to configure memory access types for guests and receive
> +         related events in userspace.
>   
>   config NEEDS_LIBELF
>         bool
--
Julien Grall