[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 1/2] x86/hpet: remove hpet_msi_read


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Roger Pau Monne <roger.pau@xxxxxxxxxx>
  • Date: Tue, 22 Sep 2020 16:32:44 +0200
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Roger Pau Monne <roger.pau@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Tue, 22 Sep 2020 14:33:21 +0000
  • Ironport-sdr: GU3qsKjDio2n6j4iUERW9IFGQjBVErXB2sFDq4AsEHUoejDp82BDGJr/ET6YX/5HrPPKm/NgLi b49GhoEZAv4p/L5cXeCCPWzEpCBLcyuUFylmjPI36MslNjxzxpyOneWKuY+Wt/YQYK4BGSDYiN t/f63CXIhmk3+bGRXn9jnqnVFGTwUwyBj3HIDclXd4/6g4TI1nV3LIRsvOXFLXPL9SXXsnSaZn tyO7PV/Mz1NTbRE2+2U+rNz5s3ObkVphax7YrD4SQRqKFUtGR/hpt3Av2QvYY6XhCFF5gOYOXr uos=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

It's dead code, even more now that read_msi_msg has been removed.

Suggested-by: Jan Beulich <jbeulich@xxxxxxxx>
Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
---
 xen/arch/x86/hpet.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/xen/arch/x86/hpet.c b/xen/arch/x86/hpet.c
index 154c67423b..a55e68e6f7 100644
--- a/xen/arch/x86/hpet.c
+++ b/xen/arch/x86/hpet.c
@@ -268,16 +268,6 @@ static int hpet_msi_write(struct hpet_event_channel *ch, 
struct msi_msg *msg)
     return 0;
 }
 
-static void __maybe_unused
-hpet_msi_read(struct hpet_event_channel *ch, struct msi_msg *msg)
-{
-    msg->data = hpet_read32(HPET_Tn_ROUTE(ch->idx));
-    msg->address_lo = hpet_read32(HPET_Tn_ROUTE(ch->idx) + 4);
-    msg->address_hi = MSI_ADDR_BASE_HI;
-    if ( iommu_intremap )
-        iommu_read_msi_from_ire(&ch->msi, msg);
-}
-
 static unsigned int hpet_msi_startup(struct irq_desc *desc)
 {
     hpet_msi_unmask(desc);
-- 
2.28.0




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.