Re: [PATCH v3 07/22] drm/imx/dcss: Initialize DRM driver instance with CMA helper macro

[Laurentiu Palcu <laurentiu.palcu@xxxxxxxxxxx>]

Hi Thomas,

On Wed, Sep 23, 2020 at 12:21:44PM +0200, Thomas Zimmermann wrote:
> The i.MX DCSS driver uses CMA helpers with default callback functions.
> Initialize the driver structure with the rsp CMA helper macro. The
> driver is being converted to use GEM object functions as part of
> this change.
> 
> Two callbacks, .gem_prime_export and .gem_prime_import, were initialized
> to their default implementations, so they are just kept empty now.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> ---

Reviewed-by: Laurentiu Palcu <laurentiu.palcu@xxxxxxxxxxx>

Thanks,
laurentiu

>  drivers/gpu/drm/imx/dcss/dcss-kms.c | 14 +-------------
>  1 file changed, 1 insertion(+), 13 deletions(-)
> 
> diff --git a/drivers/gpu/drm/imx/dcss/dcss-kms.c 
> b/drivers/gpu/drm/imx/dcss/dcss-kms.c
> index 135a62366ab8..b72e5cef7e40 100644
> --- a/drivers/gpu/drm/imx/dcss/dcss-kms.c
> +++ b/drivers/gpu/drm/imx/dcss/dcss-kms.c
> @@ -28,19 +28,7 @@ static const struct drm_mode_config_funcs 
> dcss_drm_mode_config_funcs = {
>  
>  static struct drm_driver dcss_kms_driver = {
>       .driver_features        = DRIVER_MODESET | DRIVER_GEM | DRIVER_ATOMIC,
> -     .gem_free_object_unlocked = drm_gem_cma_free_object,
> -     .gem_vm_ops             = &drm_gem_cma_vm_ops,
> -     .dumb_create            = drm_gem_cma_dumb_create,
> -
> -     .prime_handle_to_fd     = drm_gem_prime_handle_to_fd,
> -     .prime_fd_to_handle     = drm_gem_prime_fd_to_handle,
> -     .gem_prime_import       = drm_gem_prime_import,
> -     .gem_prime_export       = drm_gem_prime_export,
> -     .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table,
> -     .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table,
> -     .gem_prime_vmap         = drm_gem_cma_prime_vmap,
> -     .gem_prime_vunmap       = drm_gem_cma_prime_vunmap,
> -     .gem_prime_mmap         = drm_gem_cma_prime_mmap,
> +     DRM_GEM_CMA_DRIVER_OPS,
>       .fops                   = &dcss_cma_fops,
>       .name                   = "imx-dcss",
>       .desc                   = "i.MX8MQ Display Subsystem",
> -- 
> 2.28.0
>