Re: [PATCH 5/9] lib: move parse_size_and_unit()

[Jan Beulich <jbeulich@xxxxxxxx>]

On 22.09.2020 21:41, Andrew Cooper wrote:
> On 14/09/2020 11:17, Jan Beulich wrote:
>> ... into its own CU, to build it into an archive.
> 
> CU?

Compilation Unit - we've been using this acronym in a number of
cases, I think.

> Irrespective, it seems very weird to carve this out, seeing as it is
> called from a number of core locations, and depends on other core
> functions which aren't split out.

As said in the cover letter, the goal is to get rid of common/lib.c
as a whole. It's a bad file name for _anything_ to live in, as from
its name you can't really derive what may or may not be (or belong)
in there.

Depending on other core functions isn't a problem at all for stuff
living in archives. It being called "from a number of core
locations" isn't a convincing argument either, as all of those could
potentially be inside some #ifdef CONFIG_*. However, if it is
believed that this would better live in an object file than in an
archive, I can easily move it from lib-y to obj-y.

Jan