[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Intel-gfx] [PATCH 08/11] drm/i915: use vmap in i915_gem_object_map
- To: Matthew Auld <matthew.william.auld@xxxxxxxxx>
- From: Christoph Hellwig <hch@xxxxxx>
- Date: Fri, 25 Sep 2020 18:02:42 +0200
- Cc: Christoph Hellwig <hch@xxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Matthew Wilcox <willy@xxxxxxxxxxxxx>, ML dri-devel <dri-devel@xxxxxxxxxxxxxxxxxxxxx>, linux-mm@xxxxxxxxx, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, kernel list <linux-kernel@xxxxxxxxxxxxxxx>, Intel Graphics Development <intel-gfx@xxxxxxxxxxxxxxxxxxxxx>, x86@xxxxxxxxxx, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>, Minchan Kim <minchan@xxxxxxxxxx>, Matthew Auld <matthew.auld@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, Nitin Gupta <ngupta@xxxxxxxxxx>
- Delivery-date: Fri, 25 Sep 2020 16:02:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri, Sep 25, 2020 at 03:08:59PM +0100, Matthew Auld wrote:
> > + i = 0;
> > + for_each_sgt_page(page, iter, obj->mm.pages)
> > + pages[i++] = page;
> > + vaddr = vmap(pages, n_pages, 0, pgprot);
> > + if (pages != stack)
> > + kvfree(pages);
> > + return vaddr;
> > +}
> > - return area->addr;
> > + for_each_sgt_daddr(addr, iter, obj->mm.pages)
> > + pfns[i++] = (iomap + addr) >> PAGE_SHIFT;
>
> Missing the i = 0 fix from Dan?
Yeah, looks like I only managed to apply the one in the page based
version above.
|
