[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/4] xen/arm: Unbreak ACPI


  • To: Julien Grall <julien@xxxxxxx>
  • From: Rahul Singh <Rahul.Singh@xxxxxxx>
  • Date: Tue, 29 Sep 2020 11:10:10 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hb/LMxN1oe0p93cJ8n/sEAEhpRVl9MLUwTcDytlvIlQ=; b=T9fMF+ctCWM/s7uNBT86VBaFm8LB666p+YzElwtf6GNYXPPRfeMwOR7KzOrGxmiHvw1tPs4pq+zHB3TgfWy3icHs0TMg0PDY6Qbxa66UQludI4jOK1cHZS1tq3lwZjYZIr3+VUEuTSWY8u0y1XKLYXGxu3xPwgMx4T3jF/tXtLVY7Q2DTw3Hvve6zNx6/JWqWxsOpBXDs0VI0x762/RgKKigh9Gxtfg8ZRfEPyC3/4oKc+JnTQ2xoEyUFnEdxzFP16Ck2sMyfEa8yk8SKJsx0LGN8g8VsksZD5N9Bx5mgDfYgPVi+mJhYsKEPDaf1bq3zEJNc34EKY9GoZA7C0JM5A==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SHsXl2IDak1UQsxf0TeZA4XalzvgGNPxI3lWP1rznZP9LBcUJutZvlDpQXaDPh5+h+5RGsf1f0xnb2ZICWcKYa9hrX/IO+TPmSRJLKG5oP+lLzNKl0NU8EOUXdWMpBGhdgMAm9pfAV/WgcGyvfNPNsGCQdO0jZBdPXxOe0B6X/M4XtkhckwV5XpDr0Zteu0OpzaYJYg4drOcH4PC8U6R6MI+lpicCAllVorcuuK8nYHSBT5Zmrvi/wwr2SkTJ07kXl9pSqj7GmbfsVfU6KpB/5X6OiWsOnPBSzytolJROUoq3ngHQtwUi/uTJdXSSaZtbIR5McwUqOMIdFqZx/f6LA==
  • Authentication-results-original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "alex.bennee@xxxxxxxxxx" <alex.bennee@xxxxxxxxxx>, "masami.hiramatsu@xxxxxxxxxx" <masami.hiramatsu@xxxxxxxxxx>, "ehem+xen@xxxxxxx" <ehem+xen@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Andre Przywara <Andre.Przywara@xxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Tue, 29 Sep 2020 11:10:58 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHWlEepyIutvb0zuEycmzpL14SOt6l/eH4A
  • Thread-topic: [PATCH 0/4] xen/arm: Unbreak ACPI

Hello,

> On 26 Sep 2020, at 9:55 pm, Julien Grall <julien@xxxxxxx> wrote:
> 
> From: Julien Grall <jgrall@xxxxxxxxxx>
> 
> Hi all,
> 
> Xen on ARM has been broken for quite a while on ACPI systems. This
> series aims to fix it.

We also observed the panic after enabling the ACPI for ARM N1SDP board earlier.

(XEN) Xen call trace:
(XEN)    [<0000000000271b24>] set_fixmap+0x28/0x2c (PC)
(XEN)    [<0000000000271b18>] set_fixmap+0x1c/0x2c (LR)
(XEN)    [<0000000000267d58>] __acpi_map_table+0x38/0x94
(XEN)    [<00000000002501a4>] acpi_os_map_memory+0x18/0x64

After applying this patch series panic is fixed and XEN is able to boot with 
ACPI enabled. 

> 
> Unfortunately I don't have a system with ACPI v6.0 or later (QEMU seems
> to only support 5.1). So I did only some light testing.
> 
> I have only build tested the x86 side so far.
> 
> Cheers,
> 
> *** BLURB HERE ***
> 
> Julien Grall (4):
>  xen/acpi: Rework acpi_os_map_memory() and acpi_os_unmap_memory()
>  xen/arm: acpi: The fixmap area should always be cleared during
>    failure/unmap
>  xen/arm: Check if the platform is not using ACPI before initializing
>    Dom0less
>  xen/arm: Introduce fw_unreserved_regions() and use it
> 
> xen/arch/arm/acpi/lib.c     | 79 ++++++++++++++++++++++++++++++-------
> xen/arch/arm/kernel.c       |  2 +-
> xen/arch/arm/setup.c        | 25 +++++++++---
> xen/arch/x86/acpi/lib.c     | 18 +++++++++
> xen/drivers/acpi/osl.c      | 34 ++++++++--------
> xen/include/asm-arm/setup.h |  2 +-
> xen/include/xen/acpi.h      |  1 +
> 7 files changed, 123 insertions(+), 38 deletions(-)
> 
> -- 
> 2.17.1
> 
> 




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.