[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/4] xen/arm: Check if the platform is not using ACPI before initializing Dom0less
- To: Julien Grall <julien@xxxxxxx>
- From: Rahul Singh <Rahul.Singh@xxxxxxx>
- Date: Tue, 29 Sep 2020 11:17:15 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gLt3vkj86JLmXzJIEcEx/M/UEnaL/3OUIRG+nGV7ckY=; b=L+H48jsdC5SJM4/Z9YColwZTG29pps3Yw/TNWBCeJIwcCdiKnLjd94gkAnNzL3IMU0J9bV7ci/R3sJxfndGcAC9g83Sw28KXQWTjkTPHa5mM4awq4B7q5hcVMoBuyj7XLe0ONNRI+eQe0HZbBQIYrsJK4t9GzEZJVnQJUiifIqrASvn76yniXbjV39t72iShRvgWto3QkL2cAyfeRNDrWULZ/4J44owVA0zKNdRODG/HOWuY9QUwqcmcYa/Pnu1JdHy3Y7lOdoBdf6FTjnt7hkZq3T6jCenHk1SZUM31LE4eu/epgiuxEKNEhtNBI+KjhKDEgF1AsL7eJdwFWXHnrQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GL1tvGQ1MinQCD+yIiopyO0V/vPvTUu2HDD4iuKsgMuYNWApHanjnxE/v6XGljFXbxSHR1uGx31eWzWkuvZ6IQzUqMuxDv6gHPi2Oe3W1tECkioTjo9vTz4SfqrUaaPvWd4Ce74KHRB5kRmeGgg4Al3IjLW2UCFOJXsaPnd4w/vtPhPCgTzNDqvB63G/4BJspuacZFRf2BSmMJ9m4SluTl2DKTz0sv+8OwgmlNpS3DDxPlhyAs1mrvpW9rGPIQw59xu4yhCYpiYf0sUklAEJ7t8YiBCqmWHAXxVjPznU3cgKEYduW8qf/QIdB+W5efd+cKeijfB3z45FEiWAtvkLbg==
- Authentication-results-original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "alex.bennee@xxxxxxxxxx" <alex.bennee@xxxxxxxxxx>, "masami.hiramatsu@xxxxxxxxxx" <masami.hiramatsu@xxxxxxxxxx>, "ehem+xen@xxxxxxx" <ehem+xen@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Andre Przywara <Andre.Przywara@xxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 29 Sep 2020 11:18:02 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHWlEesX+v/cDvKNkKA7E4bt1Fvbal/e5oA
- Thread-topic: [PATCH 3/4] xen/arm: Check if the platform is not using ACPI before initializing Dom0less
Hello
> On 26 Sep 2020, at 9:55 pm, Julien Grall <julien@xxxxxxx> wrote:
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> Dom0less requires a device-tree. However, since commit 6e3e77120378
> "xen/arm: setup: Relocate the Device-Tree later on in the boot", the
> device-tree will not get unflatten when using ACPI.
>
> This will lead to a crash during boot.
>
> Given the complexity to setup dom0less with ACPI (for instance how to
> assign device?), we should skip any code related to Dom0less when using
> ACPI.
>
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
Reviewed-by: Rahul Singh <rahul.singh@xxxxxxx>
Tested-by: Rahul Singh <rahul.singh@xxxxxxx>
> ---
> xen/arch/arm/setup.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
> index f16b33fa87a2..35e5bee04efa 100644
> --- a/xen/arch/arm/setup.c
> +++ b/xen/arch/arm/setup.c
> @@ -987,7 +987,8 @@ void __init start_xen(unsigned long boot_phys_offset,
>
> system_state = SYS_STATE_active;
>
> - create_domUs();
> + if ( acpi_disabled )
> + create_domUs();
>
> domain_unpause_by_systemcontroller(dom0);
>
> --
> 2.17.1
>
>
Regards,
Rahul
|
