Re: [PATCH v7 1/5] efi/boot.c: add file.need_to_free

[Trammell Hudson <hudson@xxxxxxxx>]

On Wednesday, September 30, 2020 2:49 AM, Jan Beulich <jbeulich@xxxxxxxx> wrote:
> On 29.09.2020 20:17, Trammell Hudson wrote:
> > -   if ( dtbfile.addr && dtbfile.size )
> > -   if ( dtbfile.need_to_free )
> >     efi_bs->FreePages(dtbfile.addr, PFN_UP(dtbfile.size));
> >     if ( memmap )
> >     efi_bs->FreePool(memmap);
> >
>
> I'm afraid this isn't enough of a change for Arm, due to what
> fdt_increase_size() may do.

You're right.  It looks like there are also potential memory leaks
in the fdt_increase_size() error paths as well.  I've added free
calls in v8.

--
Trammell