Re: [PATCH 3/8] xen/domctl: Introduce and use XEN_DOMCTL_CDF_nested_virt

[Edwin Torok <edvin.torok@xxxxxxxxxx>]

On Wed, 2020-09-30 at 14:42 +0100, Andrew Cooper wrote:
> Like other major areas of functionality, nested virt (or not) needs
> to be
> known at domain creation time for sensible CPUID handling, and wants
> to be
> known this early for sensible infrastructure handling in Xen.
> 
> Introduce XEN_DOMCTL_CDF_nested_virt and modify libxl to set it
> appropriately
> when creating domains.  There is no need to adjust the ARM logic to
> reject the
> use of this new flag.
> 
> No functional change yet.
> [...]
> diff --git a/tools/ocaml/libs/xc/xenctrl.ml
> b/tools/ocaml/libs/xc/xenctrl.ml
> index 497ded7ce2..e878699b0a 100644
> --- a/tools/ocaml/libs/xc/xenctrl.ml
> +++ b/tools/ocaml/libs/xc/xenctrl.ml
> @@ -64,6 +64,7 @@ type domain_create_flag =
>       | CDF_OOS_OFF
>       | CDF_XS_DOMAIN
>       | CDF_IOMMU
> +     | CDF_NESTED_VIRT
>  
>  type domain_create_iommu_opts =
>       | IOMMU_NO_SHAREPT
> diff --git a/tools/ocaml/libs/xc/xenctrl.mli
> b/tools/ocaml/libs/xc/xenctrl.mli
> index f7f6ec570d..e64907df8e 100644
> --- a/tools/ocaml/libs/xc/xenctrl.mli
> +++ b/tools/ocaml/libs/xc/xenctrl.mli
> @@ -57,6 +57,7 @@ type domain_create_flag =
>    | CDF_OOS_OFF
>    | CDF_XS_DOMAIN
>    | CDF_IOMMU
> +  | CDF_NESTED_VIRT

OCaml changes LGTM.
Just a reminder that we'll need to apply the xenctrl changes to the
mock xenctrl used by the xapi-project CI at 
https://github.com/lindig/xenctrl too.

Best regards,
--Edwin