[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Xen Coding style and clang-format
- To: "jbeulich@xxxxxxxx" <jbeulich@xxxxxxxx>, "George.Dunlap@xxxxxxxxxx" <George.Dunlap@xxxxxxxxxx>
- From: Anastasiia Lukianenko <Anastasiia_Lukianenko@xxxxxxxx>
- Date: Thu, 1 Oct 2020 09:06:02 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4doJ2qYtM5XtWt+iExX4kzM70iPQkK6QRgn3W6ui5bA=; b=D2NxG27ns2tvzZ6OpYyzQHGwh6C8dkBuXhSEEOXIlKFCwfo3+G10nMC/KsprtavSU9SDaaKLqYmhGovMFdBZtE6wJlukz5OTZkFj+ujB6n1Bvn5wnfXe22aYP/aaAqB7b0JMW8ucYL/sXp2u721G1uupogoVASqJTE3nQYnZdm7Jv93eHTtPO1nQur/l785WawUt+9mAfNwDAYBCZhsofAkRJQsBwmYrk8flWyyDTc/644XYlY+H4lds8gEFm9hRXEalviRNMeUJ+UUuHN238PwiW6J55TwdRDzspz6ac3hTCJgkQxMSiPNVInd1Kow9CsbdgyI4AR8D2m4nO+f+dQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z8kFqoiEMbrQZ8knMQOSDTKVxcA/kj0WUiJQCSKLhmJR8WfD7sx4e4phkqEhadmxj9CNfWGPvt1JM0Jidq1bpbbRHrJCUWo0GbO/hDCPG0YZbQrbR8tbyJNr0GYdWB5u7u+FYrMHfFGRY/I51VW5hJ0PVDqQib4u4I9jvdrVW+bM4RVd5PT0W/2xdFEhwG8aJNDQZzYELjx4AUvi7mjMjRNzNnyfIi4ps8Mw+FAwIhcnGtyJVu2zW9V3772dMAGgjRcc8dysKaszSFo+b8BhBm3rc2myNDnmYGsvTGoTlaWwyt3reyLB7aLv5KP2nDJPDknr7WdH+gGTc/rsYXEpJQ==
- Authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=epam.com;
- Cc: Artem Mygaiev <Artem_Mygaiev@xxxxxxxx>, "committers@xxxxxxxxxxxxxx" <committers@xxxxxxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, "vicooodin@xxxxxxxxx" <vicooodin@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "viktor.mitin.19@xxxxxxxxx" <viktor.mitin.19@xxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Thu, 01 Oct 2020 09:06:34 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHWlwq4nKYEhMN38U+xmvwRsutq+amA8joAgAAHUgCAAXyKAA==
- Thread-topic: Xen Coding style and clang-format
Hi,
On Wed, 2020-09-30 at 10:24 +0000, George Dunlap wrote:
> > On Sep 30, 2020, at 10:57 AM, Jan Beulich <jbeulich@xxxxxxxx>
> > wrote:
> >
> > On 30.09.2020 11:18, Anastasiia Lukianenko wrote:
> > > I would like to know your opinion on the following coding style
> > > cases.
> > > Which option do you think is correct?
> > > 1) Function prototype when the string length is longer than the
> > > allowed
> > > one
> > > -static int __init
> > > -acpi_parse_gic_cpu_interface(struct acpi_subtable_header
> > > *header,
> > > - const unsigned long end)
> > > +static int __init acpi_parse_gic_cpu_interface(
> > > + struct acpi_subtable_header *header, const unsigned long
> > > end)
> >
> > Both variants are deemed valid style, I think (same also goes for
> > function calls with this same problem). In fact you mix two
> > different style aspects together (placement of parameter
> > declarations and placement of return type etc) - for each
> > individually both forms are deemed acceptable, I think.
>
> If we’re going to have a tool go through and report (correct?) all
> these coding style things, it’s an opportunity to think if we want to
> add new coding style requirements (or change existing requirements).
>
I am ready to discuss new requirements and implement them in rules of
the Xen Coding style checker.
> -George
Regards,
Anastasiia
|
