[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/3] x86/vLAPIC: vlapic_init() runs only once for a vCPU

  • To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Fri, 2 Oct 2020 12:19:37 +0100
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Fri, 02 Oct 2020 11:23:50 +0000
  • Ironport-sdr: EgwAj4Uoxcnso4oYxvx+hPzAfj28TInscbiawn2N8SXzRlRThilRKWcCtEZU2/Fer+pljT5c8e O6eylcsT3gwU7MgoQ/mnKluyFej/MG/yGqU0nxM2PPdpxFHuA1xB5qMWG1IDNM7X6lB5RRoXGG 2dag17paIhioFO9v7/T3D6lV6Sf8KNqXRRw8VLXkDYkVdYtVf14giGT89kNx8zj/OFvtWAt+Hb oVp8GMK1KnIQYn1lp2cHTKz+9D6vauYskdKy0BH8HXRiNBLKNKtTbcYuRIPaUYf/lkRRMWwuu6 7GI=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 02/10/2020 11:31, Jan Beulich wrote:
> Hence there's no need to guard allocation / mapping by checks whether
> the same action has been done before. I assume this was a transient
> change which should have been undone before 509529e99148 ("x86 hvm: Xen
> interface and implementation for virtual S3") got committed.
> While touching this code, switch dprintk()-s to use %pv.

Logging ENOMEM, especially without actually saying ENOMEM, is quite

> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, preferably with
the printk()s dropped.



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.