[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] build: always use BASEDIR for xen sub-directory
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Fri, 2 Oct 2020 12:44:07 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EpxC1hAnH3eF30dURg+E+4988ogzfy2wrQ97gpqhEH8=; b=IdSSY+hUipx5eNTIJW1FDbIeApNXGcF+ju7nopupe7W+Jb0yCQ9g+4O/to4SR0gs0KJSif1FQpA9Mmr8xk37G2MJXqaK9HF2knQvc+LO0zOAxVn/5KRbAa2qEjYVgopQYVI0q8RJS0CNtqmvKc+6Y3n1r2qsp2qRkRhu559EvOlR0A9krdg/gt1U3xSH7+FRWQoJJziWu9F302w5QMkQdPypCNleN2jJmITH9sXyrUTX/52azaRnqhNS6/NMGopNM+UAH8HfgstEZNQRt+1s2LkHh4kRVbojQjrZ61qrXwnoClAn+U1znce+jDJujRk6LcniVLATEeAPy5eQb+4k1Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NltaIem2qVqcU+fRuF9rAjaTz/A8QZay6aq5PClzRkpGNyVrs0UucAAVJ1Ctd00tdQ5JSoZi2IXb6cSNUHTpvskDZisXA9FeLMrFiEdtWTItRHGdxfyc/G+4HhwCeSflIzHdKFnoxgiRWC25RDLVXij5CDh3zZxFtjB9ee+iONvGccbTcaOsXtU3MAEu1GzFKXXCvRNUKI4Vv7cxLm3B9JeJGSTKQk8yuVDtUc2g6KfXbqId0W5Knaxck3nyxc4/hXWsWyti2wx7uhQuyo4Lge4yriq/PbWS7u12S1IJd2xskE7tlS2I4Gg2luEiCmMVAj4K9bg2oDDg9EbjVHjq8Q==
- Authentication-results-original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Cc: "open list:X86" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 02 Oct 2020 12:44:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHWmKjTj7VmlPYcLkSjqrrhNFG5S6mEOTwAgAAGTYCAAAEPgIAAAYQA
- Thread-topic: [PATCH] build: always use BASEDIR for xen sub-directory
> On 2 Oct 2020, at 13:38, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 02.10.2020 14:34, Bertrand Marquis wrote:
>>> On 2 Oct 2020, at 13:12, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>>>
>>> On 02.10.2020 12:42, Bertrand Marquis wrote:
>>>> Modify Makefiles using $(XEN_ROOT)/xen to use $(BASEDIR) instead.
>>>>
>>>> This is removing the dependency to xen subdirectory preventing using a
>>>> wrong configuration file when xen subdirectory is duplicated for
>>>> compilation tests.
>>>>
>>>> Signed-off-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
>>>
>>> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
>>
>> Thanks :-)
>>
>>>
>>> (but more for the slight tidying than the purpose you name)
>>
>> Feel free to remove the justification from the commit message if
>> you think it is not usefull.
>
> Oh, no, it's not like I consider it not useful. It shows how you
> arrived at making the change. It's just that I didn't consider
> making copies of xen/ something we mean to be supported. I wouldn't
> be surprised if it got broken again ...
basically i do this a “cp -rs” of xen subdirectory so that i can have
directories
in which xen is compiled for x86, arm32 and arm64 and recompile all of them
quickly without having to go through distclean, config, make each time or modify
the original tree.
If it gets broken i will fix it :-)
In the long term it is a step toward out of tree compilation (with some of the
changes already started dealing with links and other stuff).
Bertrand
|
