[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/8] xen/domctl: Introduce and use XEN_DOMCTL_CDF_nested_virt
- To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
- From: Christian Lindig <christian.lindig@xxxxxxxxxx>
- Date: Mon, 5 Oct 2020 08:32:03 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hBFWe4FusilT2++nnrktdpnGTHNllFZN9SNle7DHB/k=; b=U01yngFiqAaPcggZZNtVfhKxLoKS3sj01y83/Hdlxco0p7GiLEW2MOhp3PSjhJdacyWkEQlmnASOdycSgfk0zl9lWgbVmWwRZ0m7jtD7SD9G/+5nUsKoSudqjFvECi7H1/jwjjDkA4t1es6174IYw8iWM+OnaxgK7DRD/6EbQCSnHJoII7CxK/HnpZeoSKB5Rcd3xsZ1JPGytk9jxMBsTvCQYfaZ/qUAnHnUFt4PBTR89xEjBzH6Ld+Whtxm5uSOp91OceiDlh2FhOX1qYSQQGu/HihGabUVVIrF9YQ9pf/nx2tNsYjbjMIvMi8o/5VpRaHqlMCxI6eRvW9fwKswRg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HNNb3cdN3e2TDH9RvCj4e6njZCHlTBhXyERKbStKrZ5DSLMwjCmMxJsUjGn/Wl2Rw6DYHER+r6Wb1x5jx/AHpNNn6oF/aGjcDmzcly9rzOciaRsMebNXhiPnA/HJYi1urCQTnDTxmtVXvFKWkBgMgss/quJehudCETpFJ6mcuh1bc6bLYlWRONI7v2g+Sh/7tJPiQavnpkDFqGByWoyrMbang3sKDlflEDg2crBOG9KwX71oTZ3SbkKru+drml0ro1jSu8mqLMl3QU0gzngAExVQj8bE002PNjHOGh4T3TUCerbgs2yFtlBjplrSLOO1OcIDmGSK3nwdhEBEzU+s6Q==
- Authentication-results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Edwin Torok <edvin.torok@xxxxxxxxxx>, Rob Hoes <Rob.Hoes@xxxxxxxxxx>
- Delivery-date: Mon, 05 Oct 2020 08:32:16 +0000
- Ironport-sdr: 2Gn5YxardgT9ITyvFDjEAECuok5dQsNr7Kc5kYhqXRnrKu5uWYTqgyVsF4iqgAitcf7s88IDtF vxfkNUTfKe1j3Cag8giODm2KbiOAct5If+Ho5H6Ah7Rkk7ECMDJrcXLmHrdO6RmLig4433jZau qKq9XzLtViFV4th236uUdk0rlD1NUUdvnM7L8A6hJXUsWQrGw9BSSoKZQP0f3Z6vsUdymeU0IM zGOSlk4afIXUs+nHLmyrw95Dcm4DfKg2JKCVkVB+3kxkTEBOcgVwp/XANUzXlsn0OQtLQCjPfB nXk=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHWlzAJkAo6XskIDU6SR0iyiMzfOamCi3aAgAAK6ICABh8oLg==
- Thread-topic: [PATCH 3/8] xen/domctl: Introduce and use XEN_DOMCTL_CDF_nested_virt
--
Acked-by: Christian Lindig <christian.lindig@xxxxxxxxxx>
________________________________________
From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
Sent: 01 October 2020 12:02
To: Jan Beulich
Cc: Xen-devel; Roger Pau Monne; Wei Liu; Ian Jackson; Christian Lindig; Edwin
Torok; Rob Hoes
Subject: Re: [PATCH 3/8] xen/domctl: Introduce and use
XEN_DOMCTL_CDF_nested_virt
On 01/10/2020 11:23, Jan Beulich wrote:
> On 30.09.2020 15:42, Andrew Cooper wrote:
>> @@ -667,6 +668,12 @@ int arch_sanitise_domain_config(struct
>> xen_domctl_createdomain *config)
>> */
>> config->flags |= XEN_DOMCTL_CDF_oos_off;
>>
>> + if ( nested_virt && !hap )
>> + {
>> + dprintk(XENLOG_INFO, "Nested virt not supported without HAP\n");
>> + return -EINVAL;
>> + }
> Initially I was merely puzzled by this not being accompanied by
> any removal of code elsewhere. But when I started looking I couldn't
> find any such enforcement, but e.g. did find nsvm_vcpu_hostrestore()
> covering the shadow mode case. For this to be "No functional change
> yet" as the description claims, could you point me at where this
> restriction is currently enforced?
Currently enforced in the HVM_PARAM_NESTEDHVM write side effect, which
is deleted in patch 5.
~Andrew
|
