[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: print update firmware only once
- To: Julien Grall <julien@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Wed, 7 Oct 2020 13:38:34 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PK77OV8/GB8TglcADKjZCm5195Qv3S+HIUiX4hwY+sg=; b=V5kyYx+X7/pP3KuR8nUibta5rjPJuCUyy5fnqQbmLcq8ZELocOiDqUrtuMFfiFjq+gKM8cTdmGXaJSBWth/ohLXwwMf1Uh7xqeLPXKh6QBPk+Cl7/bVSoPWpEzW6wsBmPqbIKxiRJ7da+30YSEKew4KAUctzNjQoycsBxIe+8uKjZ7KebMNigSFVS1YDffcx1589UyaEwrbhqLKeiQt4qMkoXXNySglDcAOZnCFQBEDALxpq4YCvTx8bA35pPAizHNsU3544R7LgKHmrV5YUfFGrTC04yM37K+JdE/SYcd1zNWgyf0z0oH6f+Vaq/MLjxpsgr9uc/sKYMDQTjzWuvA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=It/dmHnwcPXuvLjP2DNIFaY9dmuoOK1OK+GHV+pO4NpfXBcR7kMUyU7gckZTFNr4GXuHX5mj0EnbYO1pVAo3jAiiyhJFzchoI8J+T5WQ/wEQ/XYRMls+5T9s9214zisi+N00KoMaGL8N+FV1mUGtoWn8Oe1jJ4ZQUzpHOpP2Bhp7KoqxkavfexZOoOqPDqxKbyHvv9qyGxebdVKkNy+bMXhLoN1Mtnm3pHjKzi4SEq56HNAf0tdKuDIxPU49FjE3vHKCSJ1OdXRbMv6FahuzDrb0QfhX3dMipBVuKHhe914fhABbTpbqD6+ueE92IBfXsx8HnqMptb/vZ743FBkdog==
- Authentication-results-original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 07 Oct 2020 13:39:17 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHWnJnyoImxa+IrX0SG4dJuPztv2amMGmgAgAAKsQA=
- Thread-topic: [PATCH] xen/arm: print update firmware only once
> On 7 Oct 2020, at 14:00, Julien Grall <julien@xxxxxxx> wrote:
>
> Hi Bertrand,
>
> On 07/10/2020 12:05, Bertrand Marquis wrote:
>> Fix enable_smccc_arch_workaround_1 to only print the warning asking to
>> update the firmware once.
>> Signed-off-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
>> ---
>> xen/arch/arm/cpuerrata.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> diff --git a/xen/arch/arm/cpuerrata.c b/xen/arch/arm/cpuerrata.c
>> index 6c09017515..0c63dfa779 100644
>> --- a/xen/arch/arm/cpuerrata.c
>> +++ b/xen/arch/arm/cpuerrata.c
>> @@ -187,7 +187,7 @@ warn:
>> ASSERT(system_state < SYS_STATE_active);
>> warning_add("No support for ARM_SMCCC_ARCH_WORKAROUND_1.\n"
>> "Please update your firmware.\n");
>> - warned = false;
>> + warned = true;
>
> Thanks for spotting it. It looks like I introduced this bug in commit
> 976319fa3de7f98b558c87b350699fffc278effc "xen/arm64: Kill PSCI_GET_VERSION as
> a variant-2 workaround".
>
> I would suggest to add a fixes tag (can be done on commit).
If you can do it during the commit that works for me.
>
> Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>
Thanks
Cheers
Bertrand
|
