[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: xen-swiotlb vs phys_to_dma
- To: Christoph Hellwig <hch@xxxxxx>
- From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
- Date: Wed, 7 Oct 2020 10:15:46 -0700 (PDT)
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.60.83) smtp.rcpttodomain=lists.linux-foundation.org smtp.mailfrom=xilinx.com; dmarc=bestguesspass action=none header.from=xilinx.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jfuc7bfP8imoEchfCuXEL9P1/SHk38u2m1zaUF29b10=; b=eSsyUMv6MdKEImZXw2X92gM/ebZ72/T1lqakTy1mVNuxF6JDfseRgvqKb4RD9v29EFnXuktTFeLUhfMSSBKSTBiYRn/foy/olPZseQq8mSGNFknYeChoRtRt83u0kXBMt9xhp5HG/D5qC4P5mzl15t2ysDkmemWNGUwKpa0Lx2DCPxekW4vkqEd7+X1gEzQ68VXYTUZqJjAYpYifDLWSb8w35otSAlxEnESLvwAgnirQM0KMsphLHPKy2Stbq56Nn7xZ+kaEvM1gfDc+YWYNc4JJGUlUXxeASwI7zX31yeEkkhURowCcN+SHa3fFIg5hNdC/3gEFUdzxGS8Z8qkdNA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lrN2lXX+T7Udw7Z0jfKYJESY0W1XtHtoOOOgCTYYnkj90d34JIfQ8yyGHrkKROA6cjJADUbXKKu54NQNjtT1HhCUBK8y6fHSkOymiQRDHDrbU8U/t7o3Gv3CYdINF0eTlwkYSKCFaGD1OtOW25I0d/Pnu1XfaNMKP7/bLjA9DQWlC5Hk2/kJ3gTd4q4gKbu04covdHFT78kAEeLotvvM3eNQP9yoIULPqZFPstFK4lg1qK7g8KMnbF9xhdREqlzw0ITn4KkEzPThePRbn4JuSQZxBOvg8Tjk6wgLjte5Obg3wOqGafe7aS5h2zc0qrHeDk7L/rvPymCiCeQ3g+Yp9Q==
- Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 07 Oct 2020 17:16:15 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, 7 Oct 2020, Christoph Hellwig wrote:
> On Tue, Oct 06, 2020 at 01:46:12PM -0700, Stefano Stabellini wrote:
> > OK, this makes a lot of sense, and I like the patch because it makes the
> > swiotlb interface clearer.
> >
> > Just one comment below.
> >
>
> > > +phys_addr_t swiotlb_tbl_map_single(struct device *hwdev, phys_addr_t
> > > orig_addr,
> > > + size_t mapping_size, size_t alloc_size,
> > > + enum dma_data_direction dir, unsigned long attrs)
> > > {
> > > + dma_addr_t tbl_dma_addr = phys_to_dma_unencrypted(dev, io_tlb_start);
> >
> > This is supposed to be hwdev, not dev
>
> Yeah, te compiler would be rather unhappy oterwise.
>
> I'll resend it after the dma-mapping and Xen trees are merged by Linus
> to avoid a merge conflict.
Sounds good, thanks. Please add
Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
|
