[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[OSSTEST PATCH 07/82] ts-hosts-allocate-Executive: Add a comment about a warning

From: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
 ts-hosts-allocate-Executive | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/ts-hosts-allocate-Executive b/ts-hosts-allocate-Executive
index 58d2a389..78b94c6d 100755
--- a/ts-hosts-allocate-Executive
+++ b/ts-hosts-allocate-Executive
@@ -1039,6 +1039,10 @@ sub actual_allocation ($) {
            if ($shared->{ntasks}) {
                warn "resource $shrestype $shared->{resname} allegedly".
                     " available but wrong state $shared->{state} and tasks";
+               # This can happen if following a failed prep by
+               # another job, the other shares are still owned by the
+               # now-dead task.  If so that share will become allocatable
+               # (and therefore not be counted in `ntasks') in due course.
                return undef;
                 # someone was preparing it but they aren't any more



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.