[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] golang/xenlight: standardize generated code comment
- To: Nick Rosbrook <rosbrookn@xxxxxxxxx>
- From: George Dunlap <George.Dunlap@xxxxxxxxxx>
- Date: Mon, 12 Oct 2020 13:21:38 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cTgcSX37QmQcykf28E0vQqerMpNJnPSmoi6uIFIQk0M=; b=QOPZ5GvcWwfYJaA11SiqLFe1mJlCEhoK5K4GyiEeKSRFZm4/uu0tRpVt5YGIa2PJXcb1rxmBnsl9aeyPkWQxkvtADpn1Ki1y0GKsWKIv7H0e36xujhTqpcQgOalZTrUO6dnfUHb0Lg7rEIGHa+23jIiUrAYTz/mAcSY94AFzrYNLDcJFQilOMcBhDh6+AqZjxf+REV9PjmouTLT7Owduwz6Ll9AM2hOUUsNHBlKORO7XUI6MuaxHk6XtJ58behno56V9mDqohNd1UN7F5ZpzCaMs+iuABRgypprEkMf/usyT8XvmzFCrhyxvz+xI+a8SQBOzwMRG/Z5zMVS28QyULw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jn3FrhdeR2ydI1MwnVRqtJKqF7UTwSBT4/E82sOxf5HnpfA9C79UxL5txzz268faa69hyFAfWOuev12/Tk8cf63EUnO7q3r++Ihd32rL9iE/ECcR/yHSoy6giaoXkhwHRhxsf3BoIo/P+Si0m9EdwYyDaBdCBdx1XHs91JOlY/ebeol6DeJXnrWpn2HnKNsVJXuCLz/CexctmsH4PLhABr3RWwnbC6Ipx+Whk4orujrliPIWKe+YP7NSq/BD9f1c3ICnPaNHeLOXUPtLPigfaREjOUyqSOAbviJcwf7IPD/8b8eN8+gHUVVCU9ozwCy7DRSlowePYTk5QebDs2qdTw==
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Nick Rosbrook" <rosbrookn@xxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Mon, 12 Oct 2020 13:21:46 +0000
- Ironport-sdr: SFPNHpivpNQNDqZvBnZ1bEiXEp+6H7ofSCoF2QlCYW0sgcFGnBTXPxTSsh09B8lO9eTOIKzcBm zQAlFh1s+JBMxA1et6rRauArwI1W7j50TK9EPkLU5ML/qiSNugGeL01HK2YF28A7ZyoXim0jLP BK9rHnyZp2OKeoT3vajNtL6u07KtZFxiSbk8rPmX8WwXjk55RfrU3d6cGdVWMq7Vw8vK1wJqN9 DmKS3NWNyyh9fQ8YtaLdccsbOTj5LuvW1J6WVFyL6kwGW3p5FyAM4QcWGM0NjTckFnIqF33eFt +0g=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHWoCapLtpfOKLaDkuCp3d16+bqdKmT9OyA
- Thread-topic: [PATCH 2/2] golang/xenlight: standardize generated code comment
> On Oct 12, 2020, at 12:31 AM, Nick Rosbrook <rosbrookn@xxxxxxxxx> wrote:
>
> There is a standard format for generated Go code header comments, as set
> by [1]. Modify gengotypes.py to follow this standard, and use the
> additional
>
> // source: <IDL file basename>
>
> convention used by protoc-gen-go.
>
> This change is motivated by the fact that since 41aea82de2, the comment
> would include the absolute path to libxl_types.idl, therefore creating
> unintended diffs when generating code across different machines. This
> approach fixes that problem.
>
> [1] https://github.com/golang/go/issues/13560
>
> Signed-off-by: Nick Rosbrook <rosbrookn@xxxxxxxxxxxx>
Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxx>
|
