[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] tools/xenmpd: Fix gcc10 snprintf warning
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Thu, 15 Oct 2020 09:16:03 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CBezyFDMAZVTmGEBaNCHQVY0TkXGlydWSP2kyYgPJLU=; b=WJCOftNIHnPjkZAtkiRKOyqywlHEPa+YOTN0zwbiCEEE6txwNndwETsZMoWDBh3GNi1pKCXHOIFCaeomqvmBPHYeVxs4PH7RUjZA4WF9KomfWzwWr4jiIuoYmd1xmXyy8k0Ytfvf2vYGXx1xyZ2czJFBJpwYMzoU0toIBa3ARcJImaKdcmmdIzJDTtUT4Of+nAzdGi3Hx4XleamhYwwUTkVKsOc5QNHsdUQmNHf19l74oIqThqAGGjPf1xxKUJxmEQosluLP/mbrXcxxs3yYwyd0WCHA2Br5Y2uVMWcE4cIvaUqlzK2+bLhe6sirNO2rVQzr+PV8AIJ6UQgKTI1VLw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a6YKD/miVUBqsaYEPZyGM0gFgk+JVKzYidx63cSm2ZZAiiQhoah2wpIx/GIXawyFbqVmZUhJ12R5n380qeIQeM0dO3HREmMe+6R8ZoGXfWW/SCILV2QXFg2iIGSIXj72Df7AIZkfCpwnDd6w3y6ACZiwp9KBDR8eFQXJM2yIyazX3KUhLPUkb6E70QphzCD8gvLdC7iVEGI6NFxrBtWMw12bmEfOQrm+hjliQZaLvKXaIP0Rfhn7s9LMMpnBpINGhy/chzWcNHtQQRrIZ8V8NqM3Pemwt+a2qf61ucENsi4UruNo1H/EtCyBpqsImEKPey9GgxVJZ/t6OY7aWOc3Yg==
- Authentication-results-original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Cc: "open list:X86" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Thu, 15 Oct 2020 09:16:21 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHWokU2+acqwbijJUavOAENd1LPUqmYVziAgAAL2AA=
- Thread-topic: [PATCH v2] tools/xenmpd: Fix gcc10 snprintf warning
Hi,
> On 15 Oct 2020, at 09:33, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 14.10.2020 18:14, Bertrand Marquis wrote:
>> Add a check for snprintf return code and ignore the entry if we get an
>> error. This should in fact never happen and is more a trick to make gcc
>> happy and prevent compilation errors.
>>
>> This is solving the following gcc warning when compiling for arm32 host
>> platforms with optimization activated:
>> xenpmd.c:92:37: error: '%s' directive output may be truncated writing
>> between 4 and 2147483645 bytes into a region of size 271
>> [-Werror=format-truncation=]
>>
>> This is also solving the following Debian bug:
>> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=970802
>>
>> Signed-off-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
>
> Just as a nit - could you fix the typo in the prefix of the patch
> subject, to correctly name the component?
oh right pmd not mpd.
v3 on the way.
Cheers
Bertrand
|
