[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86emul: increase FPU save area in test harness/fuzzer


  • To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Thu, 22 Oct 2020 14:55:55 +0100
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Thu, 22 Oct 2020 13:56:33 +0000
  • Ironport-sdr: gQv3tFbXCV1aKSXWEhDynYlB0+Tf38pRvB7oeQfQ1VTK2Cs7wlIQguIPk2F3Ka0XYNJiWJ7gdI b4lS6e4ImYW44HUn6OTQbRqN4QHtU94Pqz6MAq8R/0A71m9ly3aB9KfbP4QjRokYbLkdw2iZlm y2f9kow374XWJnNZgz/BelcfhbfN7HmZHs60lTURW40A7JruIif8Zx1Q54NrmUfAF/Xx6OjwdC M8ORIITQLmgBxDIGqvWcKiwx+PtTydxXss4U3AaDDzecKRe1QrGlT1Bw6NDg2fzPT4Gj1P8Jqv iz0=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 22/10/2020 14:39, Jan Beulich wrote:
> Running them on a system (or emulator) with AMX support requires this
> to be quite a bit larger than 8k, to avoid triggering the assert() in
> emul_test_init(). Bump all the way up to 16k right away.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

> ---
> Intel's Software Development Emulator properly reports XSAVE-related AMX
> CPUID data for Sapphire Rapids emulation as of 8.59.0.
>
> --- a/tools/tests/x86_emulator/x86-emulate.c
> +++ b/tools/tests/x86_emulator/x86-emulate.c
> @@ -33,7 +33,7 @@
>  uint32_t mxcsr_mask = 0x0000ffbf;
>  struct cpuid_policy cp;
>  
> -static char fpu_save_area[4096] __attribute__((__aligned__((64))));
> +static char fpu_save_area[0x4000] __attribute__((__aligned__((64))));
>  static bool use_xsave;
>  
>  /*




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.