[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1] libacpi: use temporary files for generated files

  • To: Jan Beulich <jbeulich@xxxxxxxx>, Olaf Hering <olaf@xxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Tue, 27 Oct 2020 10:57:12 +0000
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 27 Oct 2020 10:57:45 +0000
  • Ironport-sdr: fqykTXJDfFdy1dgPWqYRxY0BAob9QP7nut7E7cT8mH7f48OlczC+2StQMxe2igiBbU1WA5eoeY NwGJsN9Le30nhhcMdKjj6BnR4P5nD+DAljg6INpKpImDPX/f8skfhlT1MVUwejY88JT1TE2fWd k8EUuhAOlXEmOpx4OaS+ZR/UaCs3/UL72F5x79ZRfg4O1kUR03nQihmi0nZ6f5YwEVq50OsDxt mlF6CsvFXOofQD6Dq0qn/YPZLkCR/6KMxe3oVsSdYowTNUtErpIjblNNHbqcC+uIp25uUNyqtf qYQ=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 27/10/2020 10:37, Jan Beulich wrote:
> On 27.10.2020 11:27, Olaf Hering wrote:
>> Am Tue, 27 Oct 2020 11:16:04 +0100
>> schrieb Jan Beulich <jbeulich@xxxxxxxx>:
>>> This pattern is used when a rule consists of multiple commands
>>> having their output appended to one another's.
>> My understanding is: a rule is satisfied as soon as the file exists.
> No - once make has found that a rule's commands need running, it'll
> run the full set and only check again afterwards.

It stops at the first command which fails.

Olaf is correct, but the problem here is an incremental build issue, not
a parallel build issue.

Intermediate files must not use the name of the target, or a failure and
re-build will use the (bogus) intermediate state rather than rebuilding it.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.