Re: [PATCH v1 3/4] xen/pci: Move x86 specific code to x86 directory.

[Julien Grall <julien@xxxxxxx>]

On 28/10/2020 11:51, Jan Beulich wrote:
> On 26.10.2020 18:17, Rahul Singh wrote:
> > passthrough/pci.c file is common for all architecture, but there is x86
> > sepcific code in this file.
> The code you move doesn't look to be x86 specific in the sense that
> it makes no sense on other architectures, but just because certain
> pieces are missing on Arm. With this I question whether is it really
> appropriate to move this code. I do realize that in similar earlier
> cases my questioning was mostly ignored ...
There are no plan to get support for PIRQ on Arm. All the interrupts 
will be properly sent to the guest using a virtual interrupt controller.
Regarding the code itself, there are still a few bits that are x86 
specific (see struct dev_intx_gsi_link). So I think the right action 
for now is to move the code to an x86 directory.
This can be adjusted in the future if there is another architecture that 
would require to use PIRQ.
Cheers,

--
Julien Grall