[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 14/36] qdev: Move dev->realized check to qdev_property_set()
- To: Eduardo Habkost <ehabkost@xxxxxxxxxx>
- From: Marc-André Lureau <marcandre.lureau@xxxxxxxxx>
- Date: Fri, 30 Oct 2020 12:05:23 +0400
- Cc: QEMU <qemu-devel@xxxxxxxxxx>, Matthew Rosato <mjrosato@xxxxxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Mark Cave-Ayland <mark.cave-ayland@xxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "open list:Block layer core" <qemu-block@xxxxxxxxxx>, Stefan Berger <stefanb@xxxxxxxxxxxxxxxxxx>, David Hildenbrand <david@xxxxxxxxxx>, Markus Armbruster <armbru@xxxxxxxxxx>, Halil Pasic <pasic@xxxxxxxxxxxxx>, Christian Borntraeger <borntraeger@xxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>, Artyom Tarasenko <atar4qemu@xxxxxxxxx>, Thomas Huth <thuth@xxxxxxxxxx>, Alex Williamson <alex.williamson@xxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, John Snow <jsnow@xxxxxxxxxx>, Richard Henderson <rth@xxxxxxxxxxx>, Kevin Wolf <kwolf@xxxxxxxxxx>, "Daniel P. Berrange" <berrange@xxxxxxxxxx>, Cornelia Huck <cohuck@xxxxxxxxxx>, Qemu-s390x list <qemu-s390x@xxxxxxxxxx>, Max Reitz <mreitz@xxxxxxxxxx>, Igor Mammedov <imammedo@xxxxxxxxxx>
- Delivery-date: Fri, 30 Oct 2020 08:05:46 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Every single qdev property setter function manually checks
dev->realized. We can just check dev->realized inside
qdev_property_set() instead.
The check is being added as a separate function
(qdev_prop_allow_set()) because it will become a callback later.
Signed-off-by: Eduardo Habkost <ehabkost@xxxxxxxxxx>
nice
-- Marc-André Lureau
|
