Re: [PATCH v2] tools/python: pass more -rpath-link options to ld

[Elliott Mitchell <ehem+xen@xxxxxxx>]

On Wed, Nov 04, 2020 at 03:57:49PM +0100, Jan Beulich wrote:
> --- a/tools/python/Makefile
> +++ b/tools/python/Makefile
> @@ -8,19 +8,21 @@ PY_CFLAGS = $(CFLAGS) $(PY_NOOPT_CFLAGS)
>  PY_LDFLAGS = $(SHLIB_LDFLAGS) $(APPEND_LDFLAGS)
>  INSTALL_LOG = build/installed_files.txt
>  
> +setup.py = CC="$(CC)" CFLAGS="$(PY_CFLAGS)" LDSHARED="$(CC)" 
> LDFLAGS="$(PY_LDFLAGS)" \
> +           SHLIB_libxenctrl="$(SHLIB_libxenctrl)" \
> +           SHLIB_libxenguest="$(SHLIB_libxenguest)" \
> +           SHLIB_libxenstore="$(SHLIB_libxenstore)" \
> +           $(PYTHON) setup.py
> +
>  .PHONY: build
>  build:
> -     CC="$(CC)" CFLAGS="$(PY_CFLAGS)" LDSHARED="$(CC)" 
> LDFLAGS="$(PY_LDFLAGS)" $(PYTHON) setup.py build
> +     $(setup.py) build
>  
>  .PHONY: install
>  install:
>       $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
> -
> -     CC="$(CC)" CFLAGS="$(PY_CFLAGS)" LDSHARED="$(CC)" \
> -             LDFLAGS="$(PY_LDFLAGS)" $(PYTHON) setup.py install \
> -             --record $(INSTALL_LOG) $(PYTHON_PREFIX_ARG) \
> +     $(setup.py) install --record $(INSTALL_LOG) $(PYTHON_PREFIX_ARG) \
>               --root="$(DESTDIR)" --force
> -
>       $(INSTALL_PYTHON_PROG) scripts/convert-legacy-stream 
> $(DESTDIR)$(LIBEXEC_BIN)
>       $(INSTALL_PYTHON_PROG) scripts/verify-stream-v2 $(DESTDIR)$(LIBEXEC_BIN)

Shouldn't similar work of moving all the environment variable settings to
a $(setup.py) variable be done for tools/pygrub/Makefile?

tools/python/Makefile and tools/pygrub/Makefile are presently quite
similar and keeping them similar seems a Good Idea(tm).


-- 
(\___(\___(\______          --=> 8-) EHM <=--          ______/)___/)___/)
 \BS (    |         ehem+sigmsg@xxxxxxx  PGP 87145445         |    )   /
  \_CS\   |  _____  -O #include <stddisclaimer.h> O-   _____  |   /  _/
8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445