[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Ping: [PATCH] libxl: fix libacpi dependency



On Thu, Nov 05, 2020 at 12:56:46PM +0100, Jan Beulich wrote:
> On 27.10.2020 12:40, Jan Beulich wrote:
> > $(DSDT_FILES-y) depends on the recursive make to have run in libacpi/
> > such that the file(s) itself/themselves were generated before
> > compilation gets attempted. The same, however, is also necessary for
> > generated headers, before source files including them would get
> > attempted to be compiled.
> > 
> > The dependency specified in libacpi's Makefile, otoh, is entirely
> > pointless nowadays - no compilation happens there anymore (except for
> > tools involved in building the generated files). Together with it, the
> > rule generating acpi.a also can go away.
> > 
> > Reported-by: Olaf Hering <olaf@xxxxxxxxx>
> > Fixes: 14c0d328da2b ("libxl/acpi: Build ACPI tables for HVMlite guests")
> > Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> I'd appreciate a libxl side ack (or otherwise) here.

Acked-by: Wei Liu <wl@xxxxxxx>

Feel free to commit this yourself.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.