[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 36/44] qdev: Rename qdev_get_prop_ptr() to object_field_prop_ptr()

To: Eduardo Habkost <ehabkost@xxxxxxxxxx>, qemu-devel@xxxxxxxxxx
From: Stefan Berger <stefanb@xxxxxxxxxxxxx>
Date: Thu, 5 Nov 2020 13:49:53 -0500
Cc: "Daniel P. Berrange" <berrange@xxxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Igor Mammedov <imammedo@xxxxxxxxxx>, Eric Blake <eblake@xxxxxxxxxx>, Markus Armbruster <armbru@xxxxxxxxxx>, Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>, John Snow <jsnow@xxxxxxxxxx>, Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>, Stefan Berger <stefanb@xxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Kevin Wolf <kwolf@xxxxxxxxxx>, Max Reitz <mreitz@xxxxxxxxxx>, Cornelia Huck <cohuck@xxxxxxxxxx>, Halil Pasic <pasic@xxxxxxxxxxxxx>, Christian Borntraeger <borntraeger@xxxxxxxxxx>, Richard Henderson <rth@xxxxxxxxxxx>, David Hildenbrand <david@xxxxxxxxxx>, Thomas Huth <thuth@xxxxxxxxxx>, Matthew Rosato <mjrosato@xxxxxxxxxxxxx>, Alex Williamson <alex.williamson@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, qemu-block@xxxxxxxxxx, qemu-s390x@xxxxxxxxxx
Delivery-date: Thu, 05 Nov 2020 18:50:11 +0000
List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 11/4/20 11:00 AM, Eduardo Habkost wrote:

The function will be moved to common QOM code, as it is not
specific to TYPE_DEVICE anymore.

Signed-off-by: Eduardo Habkost <ehabkost@xxxxxxxxxx>


Reviewed-by: Stefan Berger <stefanb@xxxxxxxxxxxxx>

---
Changes v1 -> v2:
* Rename to object_field_prop_ptr() instead of object_static_prop_ptr()
---
Cc: Stefan Berger <stefanb@xxxxxxxxxxxxxxxxxx>
Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
Cc: Anthony Perard <anthony.perard@xxxxxxxxxx>
Cc: Paul Durrant <paul@xxxxxxx>
Cc: Kevin Wolf <kwolf@xxxxxxxxxx>
Cc: Max Reitz <mreitz@xxxxxxxxxx>
Cc: Paolo Bonzini <pbonzini@xxxxxxxxxx>
Cc: "Daniel P. Berrangé" <berrange@xxxxxxxxxx>
Cc: Eduardo Habkost <ehabkost@xxxxxxxxxx>
Cc: Cornelia Huck <cohuck@xxxxxxxxxx>
Cc: Halil Pasic <pasic@xxxxxxxxxxxxx>
Cc: Christian Borntraeger <borntraeger@xxxxxxxxxx>
Cc: Richard Henderson <rth@xxxxxxxxxxx>
Cc: David Hildenbrand <david@xxxxxxxxxx>
Cc: Thomas Huth <thuth@xxxxxxxxxx>
Cc: Matthew Rosato <mjrosato@xxxxxxxxxxxxx>
Cc: Alex Williamson <alex.williamson@xxxxxxxxxx>
Cc: qemu-devel@xxxxxxxxxx
Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx
Cc: qemu-block@xxxxxxxxxx
Cc: qemu-s390x@xxxxxxxxxx
---
  include/hw/qdev-properties.h     |  2 +-
  backends/tpm/tpm_util.c          |  6 ++--
  hw/block/xen-block.c             |  4 +--
  hw/core/qdev-properties-system.c | 50 +++++++++++++-------------
  hw/core/qdev-properties.c        | 60 ++++++++++++++++----------------
  hw/s390x/css.c                   |  4 +--
  hw/s390x/s390-pci-bus.c          |  4 +--
  hw/vfio/pci-quirks.c             |  4 +--
  8 files changed, 67 insertions(+), 67 deletions(-)

diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h
index 7f8d5fc206..2bec65c8e5 100644
--- a/include/hw/qdev-properties.h
+++ b/include/hw/qdev-properties.h
@@ -223,7 +223,7 @@ void qdev_prop_set_macaddr(DeviceState *dev, const char 
*name,
                             const uint8_t *value);
  void qdev_prop_set_enum(DeviceState *dev, const char *name, int value);

-void *qdev_get_prop_ptr(Object *obj, Property *prop);

+void *object_field_prop_ptr(Object *obj, Property *prop);

void qdev_prop_register_global(GlobalProperty *prop);

  const GlobalProperty *qdev_find_global_prop(Object *obj,
diff --git a/backends/tpm/tpm_util.c b/backends/tpm/tpm_util.c
index 0b07cf55ea..bb1ab34a75 100644
--- a/backends/tpm/tpm_util.c
+++ b/backends/tpm/tpm_util.c
@@ -35,7 +35,7 @@
  static void get_tpm(Object *obj, Visitor *v, const char *name, void *opaque,
                      Error **errp)
  {
-    TPMBackend **be = qdev_get_prop_ptr(obj, opaque);
+    TPMBackend **be = object_field_prop_ptr(obj, opaque);
      char *p;

p = g_strdup(*be ? (*be)->id : "");

@@ -47,7 +47,7 @@ static void set_tpm(Object *obj, Visitor *v, const char 
*name, void *opaque,
                      Error **errp)
  {
      Property *prop = opaque;
-    TPMBackend *s, **be = qdev_get_prop_ptr(obj, prop);
+    TPMBackend *s, **be = object_field_prop_ptr(obj, prop);
      char *str;

if (!visit_type_str(v, name, &str, errp)) {

@@ -67,7 +67,7 @@ static void set_tpm(Object *obj, Visitor *v, const char 
*name, void *opaque,
  static void release_tpm(Object *obj, const char *name, void *opaque)
  {
      Property *prop = opaque;
-    TPMBackend **be = qdev_get_prop_ptr(obj, prop);
+    TPMBackend **be = object_field_prop_ptr(obj, prop);

if (*be) {

          tpm_backend_reset(*be);
diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c
index bd1aef63a7..718d886e5c 100644
--- a/hw/block/xen-block.c
+++ b/hw/block/xen-block.c
@@ -336,7 +336,7 @@ static void xen_block_get_vdev(Object *obj, Visitor *v, 
const char *name,
                                 void *opaque, Error **errp)
  {
      Property *prop = opaque;
-    XenBlockVdev *vdev = qdev_get_prop_ptr(obj, prop);
+    XenBlockVdev *vdev = object_field_prop_ptr(obj, prop);
      char *str;

switch (vdev->type) {

@@ -396,7 +396,7 @@ static void xen_block_set_vdev(Object *obj, Visitor *v, 
const char *name,
                                 void *opaque, Error **errp)
  {
      Property *prop = opaque;
-    XenBlockVdev *vdev = qdev_get_prop_ptr(obj, prop);
+    XenBlockVdev *vdev = object_field_prop_ptr(obj, prop);
      char *str, *p;
      const char *end;

diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-system.c

index 96a0bc5109..8781b856d3 100644
--- a/hw/core/qdev-properties-system.c
+++ b/hw/core/qdev-properties-system.c
@@ -62,7 +62,7 @@ static void get_drive(Object *obj, Visitor *v, const char 
*name, void *opaque,
                        Error **errp)
  {
      Property *prop = opaque;
-    void **ptr = qdev_get_prop_ptr(obj, prop);
+    void **ptr = object_field_prop_ptr(obj, prop);
      const char *value;
      char *p;

@@ -88,7 +88,7 @@ static void set_drive_helper(Object *obj, Visitor *v, const char *name,

  {
      DeviceState *dev = DEVICE(obj);
      Property *prop = opaque;
-    void **ptr = qdev_get_prop_ptr(obj, prop);
+    void **ptr = object_field_prop_ptr(obj, prop);
      char *str;
      BlockBackend *blk;
      bool blk_created = false;
@@ -181,7 +181,7 @@ static void release_drive(Object *obj, const char *name, 
void *opaque)
  {
      DeviceState *dev = DEVICE(obj);
      Property *prop = opaque;
-    BlockBackend **ptr = qdev_get_prop_ptr(obj, prop);
+    BlockBackend **ptr = object_field_prop_ptr(obj, prop);

if (*ptr) {

          AioContext *ctx = blk_get_aio_context(*ptr);
@@ -214,7 +214,7 @@ const PropertyInfo qdev_prop_drive_iothread = {
  static void get_chr(Object *obj, Visitor *v, const char *name, void *opaque,
                      Error **errp)
  {
-    CharBackend *be = qdev_get_prop_ptr(obj, opaque);
+    CharBackend *be = object_field_prop_ptr(obj, opaque);
      char *p;

p = g_strdup(be->chr && be->chr->label ? be->chr->label : "");

@@ -226,7 +226,7 @@ static void set_chr(Object *obj, Visitor *v, const char 
*name, void *opaque,
                      Error **errp)
  {
      Property *prop = opaque;
-    CharBackend *be = qdev_get_prop_ptr(obj, prop);
+    CharBackend *be = object_field_prop_ptr(obj, prop);
      Chardev *s;
      char *str;

@@ -262,7 +262,7 @@ static void set_chr(Object *obj, Visitor *v, const char *name, void *opaque,

  static void release_chr(Object *obj, const char *name, void *opaque)
  {
      Property *prop = opaque;
-    CharBackend *be = qdev_get_prop_ptr(obj, prop);
+    CharBackend *be = object_field_prop_ptr(obj, prop);

qemu_chr_fe_deinit(be, false);

  }
@@ -286,7 +286,7 @@ static void get_mac(Object *obj, Visitor *v, const char 
*name, void *opaque,
                      Error **errp)
  {
      Property *prop = opaque;
-    MACAddr *mac = qdev_get_prop_ptr(obj, prop);
+    MACAddr *mac = object_field_prop_ptr(obj, prop);
      char buffer[2 * 6 + 5 + 1];
      char *p = buffer;

@@ -301,7 +301,7 @@ static void set_mac(Object *obj, Visitor *v, const char *name, void *opaque,

                      Error **errp)
  {
      Property *prop = opaque;
-    MACAddr *mac = qdev_get_prop_ptr(obj, prop);
+    MACAddr *mac = object_field_prop_ptr(obj, prop);
      int i, pos;
      char *str;
      const char *p;
@@ -363,7 +363,7 @@ static void get_netdev(Object *obj, Visitor *v, const char 
*name,
                         void *opaque, Error **errp)
  {
      Property *prop = opaque;
-    NICPeers *peers_ptr = qdev_get_prop_ptr(obj, prop);
+    NICPeers *peers_ptr = object_field_prop_ptr(obj, prop);
      char *p = g_strdup(peers_ptr->ncs[0] ? peers_ptr->ncs[0]->name : "");

visit_type_str(v, name, &p, errp);

@@ -374,7 +374,7 @@ static void set_netdev(Object *obj, Visitor *v, const char 
*name,
                         void *opaque, Error **errp)
  {
      Property *prop = opaque;
-    NICPeers *peers_ptr = qdev_get_prop_ptr(obj, prop);
+    NICPeers *peers_ptr = object_field_prop_ptr(obj, prop);
      NetClientState **ncs = peers_ptr->ncs;
      NetClientState *peers[MAX_QUEUE_NUM];
      int queues, err = 0, i = 0;
@@ -436,7 +436,7 @@ static void get_audiodev(Object *obj, Visitor *v, const 
char* name,
                           void *opaque, Error **errp)
  {
      Property *prop = opaque;
-    QEMUSoundCard *card = qdev_get_prop_ptr(obj, prop);
+    QEMUSoundCard *card = object_field_prop_ptr(obj, prop);
      char *p = g_strdup(audio_get_id(card));

visit_type_str(v, name, &p, errp);

@@ -447,7 +447,7 @@ static void set_audiodev(Object *obj, Visitor *v, const 
char* name,
                           void *opaque, Error **errp)
  {
      Property *prop = opaque;
-    QEMUSoundCard *card = qdev_get_prop_ptr(obj, prop);
+    QEMUSoundCard *card = object_field_prop_ptr(obj, prop);
      AudioState *state;
      int err = 0;
      char *str;
@@ -549,7 +549,7 @@ static void set_blocksize(Object *obj, Visitor *v, const 
char *name,
  {
      DeviceState *dev = DEVICE(obj);
      Property *prop = opaque;
-    uint32_t *ptr = qdev_get_prop_ptr(obj, prop);
+    uint32_t *ptr = object_field_prop_ptr(obj, prop);
      uint64_t value;
      Error *local_err = NULL;

@@ -637,7 +637,7 @@ static void get_reserved_region(Object *obj, Visitor *v, const char *name,

                                  void *opaque, Error **errp)
  {
      Property *prop = opaque;
-    ReservedRegion *rr = qdev_get_prop_ptr(obj, prop);
+    ReservedRegion *rr = object_field_prop_ptr(obj, prop);
      char buffer[64];
      char *p = buffer;
      int rc;
@@ -653,7 +653,7 @@ static void set_reserved_region(Object *obj, Visitor *v, 
const char *name,
                                  void *opaque, Error **errp)
  {
      Property *prop = opaque;
-    ReservedRegion *rr = qdev_get_prop_ptr(obj, prop);
+    ReservedRegion *rr = object_field_prop_ptr(obj, prop);
      Error *local_err = NULL;
      const char *endptr;
      char *str;
@@ -715,7 +715,7 @@ static void set_pci_devfn(Object *obj, Visitor *v, const 
char *name,
                            void *opaque, Error **errp)
  {
      Property *prop = opaque;
-    int32_t value, *ptr = qdev_get_prop_ptr(obj, prop);
+    int32_t value, *ptr = object_field_prop_ptr(obj, prop);
      unsigned int slot, fn, n;
      char *str;

@@ -753,7 +753,7 @@ invalid:

  static int print_pci_devfn(Object *obj, Property *prop, char *dest,
                             size_t len)
  {
-    int32_t *ptr = qdev_get_prop_ptr(obj, prop);
+    int32_t *ptr = object_field_prop_ptr(obj, prop);

if (*ptr == -1) {

          return snprintf(dest, len, "<unset>");
@@ -777,7 +777,7 @@ static void get_pci_host_devaddr(Object *obj, Visitor *v, 
const char *name,
                                   void *opaque, Error **errp)
  {
      Property *prop = opaque;
-    PCIHostDeviceAddress *addr = qdev_get_prop_ptr(obj, prop);
+    PCIHostDeviceAddress *addr = object_field_prop_ptr(obj, prop);
      char buffer[] = "ffff:ff:ff.f";
      char *p = buffer;
      int rc = 0;
@@ -803,7 +803,7 @@ static void set_pci_host_devaddr(Object *obj, Visitor *v, 
const char *name,
                                   void *opaque, Error **errp)
  {
      Property *prop = opaque;
-    PCIHostDeviceAddress *addr = qdev_get_prop_ptr(obj, prop);
+    PCIHostDeviceAddress *addr = object_field_prop_ptr(obj, prop);
      char *str, *p;
      const char *e;
      unsigned long val;
@@ -892,7 +892,7 @@ static void get_prop_pcielinkspeed(Object *obj, Visitor *v, 
const char *name,
                                     void *opaque, Error **errp)
  {
      Property *prop = opaque;
-    PCIExpLinkSpeed *p = qdev_get_prop_ptr(obj, prop);
+    PCIExpLinkSpeed *p = object_field_prop_ptr(obj, prop);
      int speed;

switch (*p) {

@@ -920,7 +920,7 @@ static void set_prop_pcielinkspeed(Object *obj, Visitor *v, 
const char *name,
                                     void *opaque, Error **errp)
  {
      Property *prop = opaque;
-    PCIExpLinkSpeed *p = qdev_get_prop_ptr(obj, prop);
+    PCIExpLinkSpeed *p = object_field_prop_ptr(obj, prop);
      int speed;

if (!visit_type_enum(v, name, &speed, prop->info->enum_table,

@@ -962,7 +962,7 @@ static void get_prop_pcielinkwidth(Object *obj, Visitor *v, 
const char *name,
                                     void *opaque, Error **errp)
  {
      Property *prop = opaque;
-    PCIExpLinkWidth *p = qdev_get_prop_ptr(obj, prop);
+    PCIExpLinkWidth *p = object_field_prop_ptr(obj, prop);
      int width;

switch (*p) {

@@ -999,7 +999,7 @@ static void set_prop_pcielinkwidth(Object *obj, Visitor *v, 
const char *name,
                                     void *opaque, Error **errp)
  {
      Property *prop = opaque;
-    PCIExpLinkWidth *p = qdev_get_prop_ptr(obj, prop);
+    PCIExpLinkWidth *p = object_field_prop_ptr(obj, prop);
      int width;

if (!visit_type_enum(v, name, &width, prop->info->enum_table,

@@ -1050,7 +1050,7 @@ static void get_uuid(Object *obj, Visitor *v, const char 
*name, void *opaque,
                       Error **errp)
  {
      Property *prop = opaque;
-    QemuUUID *uuid = qdev_get_prop_ptr(obj, prop);
+    QemuUUID *uuid = object_field_prop_ptr(obj, prop);
      char buffer[UUID_FMT_LEN + 1];
      char *p = buffer;

@@ -1065,7 +1065,7 @@ static void set_uuid(Object *obj, Visitor *v, const char *name, void *opaque,

                      Error **errp)
  {
      Property *prop = opaque;
-    QemuUUID *uuid = qdev_get_prop_ptr(obj, prop);
+    QemuUUID *uuid = object_field_prop_ptr(obj, prop);
      char *str;

if (!visit_type_str(v, name, &str, errp)) {

diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c
index aeab4ae9b6..9aebd7b8a9 100644
--- a/hw/core/qdev-properties.c
+++ b/hw/core/qdev-properties.c
@@ -50,7 +50,7 @@ void qdev_prop_allow_set_link_before_realize(const Object 
*obj,
      }
  }

-void *qdev_get_prop_ptr(Object *obj, Property *prop)

+void *object_field_prop_ptr(Object *obj, Property *prop)
  {
      void *ptr = obj;
      ptr += prop->offset;
@@ -96,7 +96,7 @@ void field_prop_get_enum(Object *obj, Visitor *v, const char 
*name,
                           void *opaque, Error **errp)
  {
      Property *prop = opaque;
-    int *ptr = qdev_get_prop_ptr(obj, prop);
+    int *ptr = object_field_prop_ptr(obj, prop);

visit_type_enum(v, name, ptr, prop->info->enum_table, errp);

  }
@@ -105,7 +105,7 @@ void field_prop_set_enum(Object *obj, Visitor *v, const 
char *name,
                           void *opaque, Error **errp)
  {
      Property *prop = opaque;
-    int *ptr = qdev_get_prop_ptr(obj, prop);
+    int *ptr = object_field_prop_ptr(obj, prop);

visit_type_enum(v, name, ptr, prop->info->enum_table, errp);

  }
@@ -134,7 +134,7 @@ static uint32_t qdev_get_prop_mask(Property *prop)

static void bit_prop_set(Object *obj, Property *props, bool val)

  {
-    uint32_t *p = qdev_get_prop_ptr(obj, props);
+    uint32_t *p = object_field_prop_ptr(obj, props);
      uint32_t mask = qdev_get_prop_mask(props);
      if (val) {
          *p |= mask;
@@ -147,7 +147,7 @@ static void prop_get_bit(Object *obj, Visitor *v, const 
char *name,
                           void *opaque, Error **errp)
  {
      Property *prop = opaque;
-    uint32_t *p = qdev_get_prop_ptr(obj, prop);
+    uint32_t *p = object_field_prop_ptr(obj, prop);
      bool value = (*p & qdev_get_prop_mask(prop)) != 0;

visit_type_bool(v, name, &value, errp);

@@ -188,7 +188,7 @@ static uint64_t qdev_get_prop_mask64(Property *prop)

static void bit64_prop_set(Object *obj, Property *props, bool val)

  {
-    uint64_t *p = qdev_get_prop_ptr(obj, props);
+    uint64_t *p = object_field_prop_ptr(obj, props);
      uint64_t mask = qdev_get_prop_mask64(props);
      if (val) {
          *p |= mask;
@@ -201,7 +201,7 @@ static void prop_get_bit64(Object *obj, Visitor *v, const 
char *name,
                             void *opaque, Error **errp)
  {
      Property *prop = opaque;
-    uint64_t *p = qdev_get_prop_ptr(obj, prop);
+    uint64_t *p = object_field_prop_ptr(obj, prop);
      bool value = (*p & qdev_get_prop_mask64(prop)) != 0;

visit_type_bool(v, name, &value, errp);

@@ -233,7 +233,7 @@ static void get_bool(Object *obj, Visitor *v, const char 
*name, void *opaque,
                       Error **errp)
  {
      Property *prop = opaque;
-    bool *ptr = qdev_get_prop_ptr(obj, prop);
+    bool *ptr = object_field_prop_ptr(obj, prop);

visit_type_bool(v, name, ptr, errp);

  }
@@ -242,7 +242,7 @@ static void set_bool(Object *obj, Visitor *v, const char 
*name, void *opaque,
                       Error **errp)
  {
      Property *prop = opaque;
-    bool *ptr = qdev_get_prop_ptr(obj, prop);
+    bool *ptr = object_field_prop_ptr(obj, prop);

visit_type_bool(v, name, ptr, errp);

  }
@@ -260,7 +260,7 @@ static void get_uint8(Object *obj, Visitor *v, const char 
*name, void *opaque,
                        Error **errp)
  {
      Property *prop = opaque;
-    uint8_t *ptr = qdev_get_prop_ptr(obj, prop);
+    uint8_t *ptr = object_field_prop_ptr(obj, prop);

visit_type_uint8(v, name, ptr, errp);

  }
@@ -269,7 +269,7 @@ static void set_uint8(Object *obj, Visitor *v, const char 
*name, void *opaque,
                        Error **errp)
  {
      Property *prop = opaque;
-    uint8_t *ptr = qdev_get_prop_ptr(obj, prop);
+    uint8_t *ptr = object_field_prop_ptr(obj, prop);

visit_type_uint8(v, name, ptr, errp);

  }
@@ -299,7 +299,7 @@ static void get_uint16(Object *obj, Visitor *v, const char 
*name,
                         void *opaque, Error **errp)
  {
      Property *prop = opaque;
-    uint16_t *ptr = qdev_get_prop_ptr(obj, prop);
+    uint16_t *ptr = object_field_prop_ptr(obj, prop);

visit_type_uint16(v, name, ptr, errp);

  }
@@ -308,7 +308,7 @@ static void set_uint16(Object *obj, Visitor *v, const char 
*name,
                         void *opaque, Error **errp)
  {
      Property *prop = opaque;
-    uint16_t *ptr = qdev_get_prop_ptr(obj, prop);
+    uint16_t *ptr = object_field_prop_ptr(obj, prop);

visit_type_uint16(v, name, ptr, errp);

  }
@@ -326,7 +326,7 @@ static void get_uint32(Object *obj, Visitor *v, const char 
*name,
                         void *opaque, Error **errp)
  {
      Property *prop = opaque;
-    uint32_t *ptr = qdev_get_prop_ptr(obj, prop);
+    uint32_t *ptr = object_field_prop_ptr(obj, prop);

visit_type_uint32(v, name, ptr, errp);

  }
@@ -335,7 +335,7 @@ static void set_uint32(Object *obj, Visitor *v, const char 
*name,
                         void *opaque, Error **errp)
  {
      Property *prop = opaque;
-    uint32_t *ptr = qdev_get_prop_ptr(obj, prop);
+    uint32_t *ptr = object_field_prop_ptr(obj, prop);

visit_type_uint32(v, name, ptr, errp);

  }
@@ -344,7 +344,7 @@ void field_prop_get_int32(Object *obj, Visitor *v, const 
char *name,
                            void *opaque, Error **errp)
  {
      Property *prop = opaque;
-    int32_t *ptr = qdev_get_prop_ptr(obj, prop);
+    int32_t *ptr = object_field_prop_ptr(obj, prop);

visit_type_int32(v, name, ptr, errp);

  }
@@ -353,7 +353,7 @@ static void set_int32(Object *obj, Visitor *v, const char 
*name, void *opaque,
                        Error **errp)
  {
      Property *prop = opaque;
-    int32_t *ptr = qdev_get_prop_ptr(obj, prop);
+    int32_t *ptr = object_field_prop_ptr(obj, prop);

visit_type_int32(v, name, ptr, errp);

  }
@@ -378,7 +378,7 @@ static void get_uint64(Object *obj, Visitor *v, const char 
*name,
                         void *opaque, Error **errp)
  {
      Property *prop = opaque;
-    uint64_t *ptr = qdev_get_prop_ptr(obj, prop);
+    uint64_t *ptr = object_field_prop_ptr(obj, prop);

visit_type_uint64(v, name, ptr, errp);

  }
@@ -387,7 +387,7 @@ static void set_uint64(Object *obj, Visitor *v, const char 
*name,
                         void *opaque, Error **errp)
  {
      Property *prop = opaque;
-    uint64_t *ptr = qdev_get_prop_ptr(obj, prop);
+    uint64_t *ptr = object_field_prop_ptr(obj, prop);

visit_type_uint64(v, name, ptr, errp);

  }
@@ -396,7 +396,7 @@ static void get_int64(Object *obj, Visitor *v, const char 
*name,
                        void *opaque, Error **errp)
  {
      Property *prop = opaque;
-    int64_t *ptr = qdev_get_prop_ptr(obj, prop);
+    int64_t *ptr = object_field_prop_ptr(obj, prop);

visit_type_int64(v, name, ptr, errp);

  }
@@ -405,7 +405,7 @@ static void set_int64(Object *obj, Visitor *v, const char 
*name,
                        void *opaque, Error **errp)
  {
      Property *prop = opaque;
-    int64_t *ptr = qdev_get_prop_ptr(obj, prop);
+    int64_t *ptr = object_field_prop_ptr(obj, prop);

visit_type_int64(v, name, ptr, errp);

  }
@@ -429,14 +429,14 @@ const PropertyInfo qdev_prop_int64 = {
  static void release_string(Object *obj, const char *name, void *opaque)
  {
      Property *prop = opaque;
-    g_free(*(char **)qdev_get_prop_ptr(obj, prop));
+    g_free(*(char **)object_field_prop_ptr(obj, prop));
  }

static void get_string(Object *obj, Visitor *v, const char *name,

                         void *opaque, Error **errp)
  {
      Property *prop = opaque;
-    char **ptr = qdev_get_prop_ptr(obj, prop);
+    char **ptr = object_field_prop_ptr(obj, prop);

if (!*ptr) {

          char *str = (char *)"";
@@ -450,7 +450,7 @@ static void set_string(Object *obj, Visitor *v, const char 
*name,
                         void *opaque, Error **errp)
  {
      Property *prop = opaque;
-    char **ptr = qdev_get_prop_ptr(obj, prop);
+    char **ptr = object_field_prop_ptr(obj, prop);
      char *str;

if (!visit_type_str(v, name, &str, errp)) {

@@ -484,7 +484,7 @@ void field_prop_get_size32(Object *obj, Visitor *v, const 
char *name,
                             void *opaque, Error **errp)
  {
      Property *prop = opaque;
-    uint32_t *ptr = qdev_get_prop_ptr(obj, prop);
+    uint32_t *ptr = object_field_prop_ptr(obj, prop);
      uint64_t value = *ptr;

visit_type_size(v, name, &value, errp);

@@ -494,7 +494,7 @@ static void set_size32(Object *obj, Visitor *v, const char 
*name, void *opaque,
                         Error **errp)
  {
      Property *prop = opaque;
-    uint32_t *ptr = qdev_get_prop_ptr(obj, prop);
+    uint32_t *ptr = object_field_prop_ptr(obj, prop);
      uint64_t value;

if (!visit_type_size(v, name, &value, errp)) {

@@ -531,7 +531,7 @@ static void set_prop_arraylen(Object *obj, Visitor *v, 
const char *name,
       */
      Property *prop = opaque;
      ObjectProperty *op = object_property_find_err(obj, name, &error_abort);
-    uint32_t *alenptr = qdev_get_prop_ptr(obj, prop);
+    uint32_t *alenptr = object_field_prop_ptr(obj, prop);
      void **arrayptr = (void *)obj + prop->arrayoffset;
      void *eltptr;
      const char *arrayname;
@@ -570,7 +570,7 @@ static void set_prop_arraylen(Object *obj, Visitor *v, 
const char *name,
           * being inside the device struct.
           */
          arrayprop->offset = eltptr - (void *)obj;
-        assert(qdev_get_prop_ptr(obj, arrayprop) == eltptr);
+        assert(object_field_prop_ptr(obj, arrayprop) == eltptr);
          object_property_add_field(obj, propname, arrayprop, op->allow_set);
      }
  }
@@ -760,7 +760,7 @@ static void get_size(Object *obj, Visitor *v, const char 
*name, void *opaque,
                       Error **errp)
  {
      Property *prop = opaque;
-    uint64_t *ptr = qdev_get_prop_ptr(obj, prop);
+    uint64_t *ptr = object_field_prop_ptr(obj, prop);

visit_type_size(v, name, ptr, errp);

  }
@@ -769,7 +769,7 @@ static void set_size(Object *obj, Visitor *v, const char 
*name, void *opaque,
                       Error **errp)
  {
      Property *prop = opaque;
-    uint64_t *ptr = qdev_get_prop_ptr(obj, prop);
+    uint64_t *ptr = object_field_prop_ptr(obj, prop);

visit_type_size(v, name, ptr, errp);

  }
diff --git a/hw/s390x/css.c b/hw/s390x/css.c
index 496e2c5801..fe47751df4 100644
--- a/hw/s390x/css.c
+++ b/hw/s390x/css.c
@@ -2344,7 +2344,7 @@ static void get_css_devid(Object *obj, Visitor *v, const 
char *name,
                            void *opaque, Error **errp)
  {
      Property *prop = opaque;
-    CssDevId *dev_id = qdev_get_prop_ptr(obj, prop);
+    CssDevId *dev_id = object_field_prop_ptr(obj, prop);
      char buffer[] = "xx.x.xxxx";
      char *p = buffer;
      int r;
@@ -2373,7 +2373,7 @@ static void set_css_devid(Object *obj, Visitor *v, const 
char *name,
                            void *opaque, Error **errp)
  {
      Property *prop = opaque;
-    CssDevId *dev_id = qdev_get_prop_ptr(obj, prop);
+    CssDevId *dev_id = object_field_prop_ptr(obj, prop);
      char *str;
      int num, n1, n2;
      unsigned int cssid, ssid, devid;
diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c
index 54fac3851d..99b18d56ba 100644
--- a/hw/s390x/s390-pci-bus.c
+++ b/hw/s390x/s390-pci-bus.c
@@ -1323,7 +1323,7 @@ static void s390_pci_get_fid(Object *obj, Visitor *v, 
const char *name,
                           void *opaque, Error **errp)
  {
      Property *prop = opaque;
-    uint32_t *ptr = qdev_get_prop_ptr(obj, prop);
+    uint32_t *ptr = object_field_prop_ptr(obj, prop);

visit_type_uint32(v, name, ptr, errp);

  }
@@ -1333,7 +1333,7 @@ static void s390_pci_set_fid(Object *obj, Visitor *v, 
const char *name,
  {
      S390PCIBusDevice *zpci = S390_PCI_DEVICE(obj);
      Property *prop = opaque;
-    uint32_t *ptr = qdev_get_prop_ptr(obj, prop);
+    uint32_t *ptr = object_field_prop_ptr(obj, prop);

if (!visit_type_uint32(v, name, ptr, errp)) {

          return;
diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c
index 802979635c..fc8d63c850 100644
--- a/hw/vfio/pci-quirks.c
+++ b/hw/vfio/pci-quirks.c
@@ -1489,7 +1489,7 @@ static void get_nv_gpudirect_clique_id(Object *obj, 
Visitor *v,
                                         Error **errp)
  {
      Property *prop = opaque;
-    uint8_t *ptr = qdev_get_prop_ptr(obj, prop);
+    uint8_t *ptr = object_field_prop_ptr(obj, prop);

visit_type_uint8(v, name, ptr, errp);

  }
@@ -1499,7 +1499,7 @@ static void set_nv_gpudirect_clique_id(Object *obj, 
Visitor *v,
                                         Error **errp)
  {
      Property *prop = opaque;
-    uint8_t value, *ptr = qdev_get_prop_ptr(obj, prop);
+    uint8_t value, *ptr = object_field_prop_ptr(obj, prop);

if (!visit_type_uint8(v, name, &value, errp)) {

          return;

References:
- [PATCH v2 36/44] qdev: Rename qdev_get_prop_ptr() to object_field_prop_ptr()
  - From: Eduardo Habkost

Prev by Date: [xen-4.14-testing test] 156404: regressions - FAIL
Next by Date: [RFC PATCH 0/6] Port Linux LL/SC and LSE atomics to Xen
Previous by thread: [PATCH v2 36/44] qdev: Rename qdev_get_prop_ptr() to object_field_prop_ptr()
Next by thread: [linux-linus test] 156390: regressions - FAIL
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.