[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: traps: Don't panic when receiving an unknown debug trap
- To: Julien Grall <julien@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Fri, 6 Nov 2020 07:46:55 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H9v4xcUP4HSrs+2100MskJbUpJznskU9U2tS902rJJE=; b=Ezz8FxJZUyuNPMODd0gf9Ei9nJx8x1SgwzmUGOA44MICkTCF8145TM9GPrsD+daM+ruUD5i1z1w5br2jua7/EhXSThdbjeKFNAVynrlJNJA//f7affZXKR0m1MiYCZHHE8j+XtlAdYu/V93OgNycAs6kcr3VHzbzDamHUDBqmBqTG/2JWWbi4Nk8b9tV+CdiIGO+LxBjDUf8YUYQRXDEgecS/J2dwg+8g/VP8gLBFG15OGyiY1O4ym8tNrNIcr247pESzWFO5qB6XCpHp1iIG+rXjZGtGP/+CQPL3h9E81h6ZUBnl5+toxC2pvs/Yw1U7ETKaflHl9Lkcn8ejZIOfg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GJzlcR/Re7C1bl+N6aXw0uxmF14r/z1zn7rTGGxxa6e3e8ERBMuqDHDPA7cESn3+hdKehtzKDh9Q2Cx6J4pfu9pPaIQsyx1wdPsuweWMDMTPK7I735sUQcTRp83f0TQMqS2RZkviBaHvPD6QXOrSbapAUjOjGDKelOMt2ew5MTK2Aud1Hh7Z7H/OXUkKxTQr2XkrmEFC8bexDRLAlLy+s14FpunePAU3hml0tGbNhvdgasdqEFzgEP0Hch91MIsAInPkYJHIF/kYucR7a7B2hs8r4KFORlZ81Z0uir6mSd5cH54nW4E0aesdKaEJJ6rjKZY7xDQHNJZPOpmIsBlb/Q==
- Authentication-results-original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Fri, 06 Nov 2020 07:47:10 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHWs8NxXvjxsnR7jEOaNZeAcAn8Ham6uneA
- Thread-topic: [PATCH] xen/arm: traps: Don't panic when receiving an unknown debug trap
Hi Julien,
> On 5 Nov 2020, at 22:31, Julien Grall <julien@xxxxxxx> wrote:
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> Even if debug trap are only meant for debugging purpose, it is quite
> harsh to crash Xen if one of the trap sent by the guest is not handled.
>
> So switch from a panic() to a printk().
Very smart idea :-)
>
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
> ---
> xen/arch/arm/traps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
> index 8f40d0e0b6b1..a36f145e6739 100644
> --- a/xen/arch/arm/traps.c
> +++ b/xen/arch/arm/traps.c
> @@ -1410,7 +1410,7 @@ static void do_debug_trap(struct cpu_user_regs *regs,
> unsigned int code)
> show_execution_state(regs);
> break;
> default:
> - panic("DOM%d: Unhandled debug trap %#x\n", domid, code);
> + printk("DOM%d: Unhandled debug trap %#x\n", domid, code);
> break;
> }
> }
> --
> 2.17.1
>
>
|
