[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tools/libs/light: correct bitmap operations


  • To: Jan Beulich <jbeulich@xxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Fri, 6 Nov 2020 14:37:44 +0000
  • Authentication-results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 06 Nov 2020 14:38:31 +0000
  • Ironport-sdr: 0vu+2bSbkhQednlK5BSi9XGYZxXTAn4+VwYG5t/bokP/w2nPPHu46yLayCQlgqWNLY2Nrhwm2C h+OxNN4z0vUMbzBqJUST0DKuQ1zZeSXOatC3GxwExP1zefU7rUrk8bzAwCy8OJCTwACVQ0VqLw iuueTF42F9o+pkgGOj4fhutxMlurn+b4beyvKx8Ax2R8WYOIIIxoANfFTOY1uQOYhrq2SYW1lX WypAk8IPShlRiFus1+tCVdPSAJ60LgP207NtfJTjy4x8D/xa9pj+yHsYOT8/moDzseJC2IwDOW Yog=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 06/11/2020 14:35, Jan Beulich wrote:
> On 06.11.2020 15:05, Juergen Gross wrote:
>> Libxl bitmap operations for single bits (test, set, reset) take the bit
>> number as a signed integer without testing the value to be larger than
>> 0.
>>
>> Correct that by adding the appropriate tests.
>>
>> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> Wouldn't it be better to convert the parameter types to unsigned int?

Yes, except their in the API, so immutable.

(whether they should be in the API is a different question...)

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.