[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] docs: fix documentation about default scheduler


  • To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
  • From: George Dunlap <George.Dunlap@xxxxxxxxxx>
  • Date: Wed, 11 Nov 2020 10:12:28 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nzeKJm5vfRcS4dUFNR5EwXhpyFRAMD5LO0ZM1LgeYmg=; b=I+2AaU2hooyM3qrPRj8GfhO6QOwLkOjSOF1I8/iMTu0OptKtlx7hY3+p38Oo512DeBc81GUXmbw7Y8Uruzv/1otG7JL5h8XJIesDSlgfsjDOGdHAAteR3QqxQ/qkbzZQV08ZFl3DuDwC8tmSxxIzHPOzq0bHrfa9SPOczfHiroCn+dF0aw/7KEtGk/vTctpsFWfFFxX1/qH8bzzi9szr9hyk5UzRqdfF50uFHsd711+Bn/Ft9XxpZ4RpF1Vo0/WcAEwKhVIkctXCebGWpvkuRxvpqxvrKfK+PRYvCL/FKL/phtMAQh2pfwE/RoYU9rRWImoU076Eg+tD7NempxtlEQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Am87dsUPgFD/FbLPdQEJj2hLs3+74IQOOKCcexNY7Rzclh/JWV7zlFtY8xPi98DwVS7PlFb/lKoi/5hk7XljEBhYQwRTqobwx/SWsmAXKyYvIsvONwHqMYJrEQDRl57e7eVpCiFsrTDxI5Va6eNagDML86bM6NzuEtPd13Z9nW/WBMM78qUYeX4cNuKXA1W2qWWWYQpVHI63s8Wft4lAhKXhIIBgWB29zckAuYXplI4jQO7kl3uMhtfAN/rsCpNZLankS+5n3iPdTMXJIpBJ1eQMNz6gyorUG/HEDORKFcX8kDwWvoJz1tcg6sAkaPq9RqSGxAxxSkHB8BRZRSGE/w==
  • Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: "open list:X86" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Wed, 11 Nov 2020 10:12:45 +0000
  • Ironport-sdr: p3Dwa8KDl9lOfTDLWNthFNjxV7oSt5Tj+/+8eD2hOKQb6IZ2qfJiU1K3tzWupcUWH1F+2x9pPU T0Ju46dFZOV5aYqWtbugZq2rFBPugsQK6iYB/1v/9Az9b2IoXoVC0oIpnnaMvVLg5ISptgk4SH nPz4+9CzkgAXeNLz2lEiY26+GpuG9nGd2P0tqq+X6VORGd6btk2f0UleH6acUDfM4KSliYTFZ+ TNTs8PxBIuPRbmn2sKok9z1f1rT0HucJ9DiEn5SxtbndXJc4SzVgCUhnvWVuShJI5d97t8UYst TZc=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHWt5KEiHxEu0uY0Eat6hiwYn2hl6nCtyuA
  • Thread-topic: [PATCH] docs: fix documentation about default scheduler


> On Nov 10, 2020, at 6:51 PM, Roger Pau Monne <roger.pau@xxxxxxxxxx> wrote:
> 
> Fix the command line document to account for the default scheduler not
> being credit anymore likely, and the fact that it's selectable from
> Kconfig and thus different builds could end up with different default
> schedulers.
> 
> Fixes: dafd936dddbd ('Make credit2 the default scheduler')
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> ---
> Changes since v1:
> - Point that the default scheduler is being selected by Kconfig,
>   don't mention the default Kconfig selection.
> ---
> docs/misc/xen-command-line.pandoc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/docs/misc/xen-command-line.pandoc 
> b/docs/misc/xen-command-line.pandoc
> index 4ae9391fcd..eb1db25f92 100644
> --- a/docs/misc/xen-command-line.pandoc
> +++ b/docs/misc/xen-command-line.pandoc
> @@ -1876,7 +1876,7 @@ with read and write permissions.
> ### sched
>> `= credit | credit2 | arinc653 | rtds | null`
> 
> -> Default: `sched=credit`
> +> Default: selectable via Kconfig.  Depends on enabled schedulers.

Sorry for not weighing in earlier; but this basically makes this documentation 
useless.

I’d rather say:

—>8

= credit | credit2 …

Default: sched=credit2

NB that default scheduler and schedulers available can be modified via Kconfig.

8<----

 -George

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.