[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [SUSPECTED SPAM][PATCH 01/10] pci/pvh: Allow PCI toolstack code run with PVH domains on ARM
- To: Oleksandr Andrushchenko <andr2000@xxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Wed, 11 Nov 2020 13:31:50 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UMSgqEL7BYtggw2p1pxICEx1c2/JyeBlvGnY2tMPgu8=; b=jKKLO5sz4x50jstD09X+u04iyeAiFw/VmrZhThkA+S5qXgNygqnNWHOswhgnJk2mdOaEqdJZR65m/P9HORS6HbamTJTnMbqwzNaGEUCvso/An7yGCPjjB+T39MWIquhxjHbkizTQ77hJKk6+qD2f3+uGVmiBl29ei22GtcWiTuCqvkeIjPlbAn6KJrrMzXwDsKzqsdlJ6Do5+OGnFLS3DH6Mjugi7pPzjFPNAhaGEcN0tub+UFTdZ4vS5cjb4uWUZ/VFeAS2Ea3u+8B2gu8TRQJa1e/n6uTAjVG5Zjkv6z6p1GX52ykwnNza+z+3FfM8/2r9ESzFl6zRrk2YeMlw+A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MBOFs+GzVKGxWfgbMgoKvb5cu7YP7CQjxTLA/Ac5lSv8KXuafzODJcDDFGLacBPrAslJGzekQq04CELy5OlO0yrXAogrzSAeZDVgA+NlFn0bPch+nm0Mm8Uezf9UHv9lyI6nI8xFiV83TdCZ0ytURDZ2aM0bBgzMJadBjPKWgnHJ/bh5+LevomUhPUSK6y46U3oW5g6ljbFgSNdiwygYEhGAVfT1u+1j2XFgKX7Q0V63qZu0DmZ28SA2rz5iRA/w5EBnrngFwlpqVX//3yQDGW6ZrxV6EHnzxzq0cxTstj2cKl93vGOuy9af4JdpBUBZ+GJBHOn+AQ2fC4xdd44q2A==
- Authentication-results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: <Rahul.Singh@xxxxxxx>, <Bertrand.Marquis@xxxxxxx>, <julien.grall@xxxxxxx>, <jbeulich@xxxxxxxx>, <sstabellini@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>, <iwj@xxxxxxxxxxxxxx>, <wl@xxxxxxx>, Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
- Delivery-date: Wed, 11 Nov 2020 12:32:08 +0000
- Ironport-sdr: rDylXtWvm8lU2NfmA01NuS0AWhKrgxt/oyU1iodSuT0ZLAME3b3zXvCEkBxJZYPmsxqDf7o9TS mHnUaZlmuVvuYiSfHiYvz6f/7eCKdI916HfxHGndD9H1As+1HGOvYecAQtgZ0WKrGveKfvqm7W famIo/Hjhv+ka0gmdwr/0anRaSmOWTnQLDIqPD4PMzIeg6PNPy81b3BiFtvlMg8bo8zX7mYwqh c3CKXjVhQ8gVjOOcrCtvWRWnwTi8+raQgkGRZcadcnkXbdZe9Dmjib9TTiCmFn21AxbG9f/5FZ gvc=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Nov 09, 2020 at 02:50:22PM +0200, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
>
> According to https://wiki.xenproject.org/wiki/Linux_PVH:
>
> Items not supported by PVH
> - PCI pass through (as of Xen 4.10)
>
> Allow running PCI remove code on ARM and do not assert for PVH domains.
>
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
> ---
> tools/libxl/Makefile | 4 ++++
> tools/libxl/libxl_pci.c | 4 +++-
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
> index 241da7fff6f4..f3806aafcb4e 100644
> --- a/tools/libxl/Makefile
> +++ b/tools/libxl/Makefile
> @@ -130,6 +130,10 @@ endif
>
> LIBXL_LIBS += -lyajl
>
> +ifeq ($(CONFIG_ARM),y)
> +CFALGS += -DCONFIG_ARM
> +endif
> +
> LIBXL_OBJS = flexarray.o libxl.o libxl_create.o libxl_dm.o libxl_pci.o \
> libxl_dom.o libxl_exec.o libxl_xshelp.o libxl_device.o \
> libxl_internal.o libxl_utils.o libxl_uuid.o \
> diff --git a/tools/libxl/libxl_pci.c b/tools/libxl/libxl_pci.c
> index bc5843b13701..b93cf976642b 100644
> --- a/tools/libxl/libxl_pci.c
> +++ b/tools/libxl/libxl_pci.c
> @@ -1915,8 +1915,10 @@ static void do_pci_remove(libxl__egc *egc, uint32_t
> domid,
> goto out_fail;
> }
> } else {
> + /* PCI passthrough can also run on ARM PVH */
> +#ifndef CONFIG_ARM
> assert(type == LIBXL_DOMAIN_TYPE_PV);
> -
> +#endif
I would just remove the assert now if this is to be used by Arm and
you don't need to fork the file for Arm.
Roger.
|
