Re: [PATCH 01/12] xen/cpupool: add cpu to sched_res_mask when removing it from cpupool

[Jürgen Groß <jgross@xxxxxxxx>]

On 11.11.20 15:32, Dario Faggioli wrote:
> On Mon, 2020-10-26 at 10:13 +0100, Juergen Gross wrote:
> > When a cpu is removed from a cpupool and added to the free cpus it
> > should be added to sched_res_mask, too.
> >
> > The related removal from sched_res_mask in case of core scheduling
> > is already done in schedule_cpu_add().
> >
> > As long as all cpupools share the same scheduling granularity there
> > is nothing going wrong with the missing removal,
> This patch is adding an addition of the CPU to sched_res_mask, which
> was missing... So isn't the above "there is nothing going wrong with
> the missing addition", or something like that?
Oh yes, of course.

Will fix that.

> Or, if it's an actual missing removal that we are referring to here,
> then it must be clarified which one.
>
> > but this will change
> > when per-cpupool granularity is fully supported.
> >
> > Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> With the above fixed or clarified:
>
> Reviewed-by: Dario Faggioli <dfaggioli@xxxxxxxx>
Thanks,


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: application/pgp-keys

Attachment: OpenPGP_signature
Description: OpenPGP digital signature