Re: [PATCH v3 09/53] qdev: Make qdev_get_prop_ptr() get Object* arg

[Cornelia Huck <cohuck@xxxxxxxxxx>]

On Thu, 12 Nov 2020 16:43:06 -0500
Eduardo Habkost <ehabkost@xxxxxxxxxx> wrote:

> Make the code more generic and not specific to TYPE_DEVICE.
> 
> Reviewed-by: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>
> Signed-off-by: Eduardo Habkost <ehabkost@xxxxxxxxxx>
> ---
> Changes v1 -> v2:
> - Fix build error with CONFIG_XEN
>   I took the liberty of keeping the Reviewed-by line from
>   Marc-André as the build fix is a trivial one line change
> ---
> Cc: Stefan Berger <stefanb@xxxxxxxxxxxxxxxxxx>
> Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> Cc: Anthony Perard <anthony.perard@xxxxxxxxxx>
> Cc: Paul Durrant <paul@xxxxxxx>
> Cc: Kevin Wolf <kwolf@xxxxxxxxxx>
> Cc: Max Reitz <mreitz@xxxxxxxxxx>
> Cc: Paolo Bonzini <pbonzini@xxxxxxxxxx>
> Cc: "Daniel P. Berrangé" <berrange@xxxxxxxxxx>
> Cc: Eduardo Habkost <ehabkost@xxxxxxxxxx>
> Cc: Cornelia Huck <cohuck@xxxxxxxxxx>
> Cc: Thomas Huth <thuth@xxxxxxxxxx>
> Cc: Richard Henderson <rth@xxxxxxxxxxx>
> Cc: David Hildenbrand <david@xxxxxxxxxx>
> Cc: Halil Pasic <pasic@xxxxxxxxxxxxx>
> Cc: Christian Borntraeger <borntraeger@xxxxxxxxxx>
> Cc: Matthew Rosato <mjrosato@xxxxxxxxxxxxx>
> Cc: Alex Williamson <alex.williamson@xxxxxxxxxx>
> Cc: qemu-devel@xxxxxxxxxx
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: qemu-block@xxxxxxxxxx
> Cc: qemu-s390x@xxxxxxxxxx
> ---
>  include/hw/qdev-properties.h     |  2 +-
>  backends/tpm/tpm_util.c          |  8 ++--
>  hw/block/xen-block.c             |  5 +-
>  hw/core/qdev-properties-system.c | 57 +++++++++-------------
>  hw/core/qdev-properties.c        | 82 +++++++++++++-------------------
>  hw/s390x/css.c                   |  5 +-
>  hw/s390x/s390-pci-bus.c          |  4 +-
>  hw/vfio/pci-quirks.c             |  5 +-
>  8 files changed, 68 insertions(+), 100 deletions(-)

Reviewed-by: Cornelia Huck <cohuck@xxxxxxxxxx> #s390 parts