[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/3] xen/pci: Move x86 specific code to x86 directory.
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Rahul Singh <Rahul.Singh@xxxxxxx>
- Date: Tue, 17 Nov 2020 16:52:56 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f+oQyniPepmnOVJ6lwHyL6t/EAAi8uZDDV9+CNCxSl4=; b=hTyInCmf1co6FRsGU7oxMxKYQfWW9OkxgUfGxV4YwbaXeb9QhE/nssrhrUraye32vUj3IQCnKwE6n70nvbU+f/UtvYXPhpM4eqRO+NYRr2kaFlIRMM4zyUGUf6Qmp0xeNeU/urC0yWhLX/HGpu4wDhxvLk2NF5aDTun19RQz7bvESwvzx671LOihZDrsAE3iR/WSQN+zhP5bU6enf3GAT3V4Ib/P+zzRFC+BFh8Ay5eXdlaKBFBda3VohYvvefa9BIOtYvO12K7SkpNox9MQ+5CmQfH0qNNsq3znwExUMIE0YXzNK0SJKa6G5LmV8cCbkAcdE++sYbPK+Xgtld+u4Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FYk+MsV32nmsY9qMTK/M/bwtFtA21yzfVv5gaR1U8e6HMfBdtdzbdgtNL6fc0hoXoGIT7rcMC1UEKzsfi/lE1fjrO5JJrAqMq2XrJtBOfVQ8syP5O+jlHvfmn0i7UUmnvZmMbWojesQoi920btplOwzsqm0WnJDnwjk3tJoge7vctMaOhb2rHvF7mIXDOtmgFjV6xhJASaINTbv8Yqf22Hn360jp3ooy9s8fWbqHn6DbWqFC5TQpBJNAKgJRrTKI0BWUTe9SMuRoe9OIc4GCb7cLS0ZALl8sYQnMPT3zeb0YmGCV+GULpTJfwyi1B07Z+XGo+HBn4+4/2pd3dv31Tg==
- Authentication-results-original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 17 Nov 2020 16:53:25 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHWvBPDynVNQDWjWUaLWbo/nKPcx6nMKoUAgABhhIA=
- Thread-topic: [PATCH v3 2/3] xen/pci: Move x86 specific code to x86 directory.
Hello Jan,
> On 17 Nov 2020, at 11:03 am, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 16.11.2020 13:25, Rahul Singh wrote:
>> passthrough/pci.c file is common for all architecture, but there is x86
>> specific code in this file.
>
> In how far is ...
>
>> @@ -1370,13 +1301,6 @@ static int __init setup_dump_pcidevs(void)
>> }
>> __initcall(setup_dump_pcidevs);
>>
>> -int iommu_update_ire_from_msi(
>> - struct msi_desc *msi_desc, struct msi_msg *msg)
>> -{
>> - return iommu_intremap
>> - ? iommu_call(&iommu_ops, update_ire_from_msi, msi_desc, msg) : 0;
>> -}
>
> ... this code x86-specific? The hook being called lives in a
> #ifdef CONFIG_HAS_PCI section, and MSI is a general PCI sub-
> feature. IOW if this is another workaround, it should be
> called so (if there's really no other way to address whatever
> issue there is), which in turn likely means it wants to be in
> a separate patch.
>
As of now there is no implementation for ARM to remap the interrupt and
interrupt remapping is enabled for x86 only so I thought I will move this code
to x86 file as this function is called from the x86 specific code only.
I will remove this code form this patch and will fix this once once will have
proper MSI implementation for ARM.
> Jan
|
