|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: AW: AW: AW: AW: Xen data from meta-virtualization layer
Hi, On 17/11/2020 23:53, Stefano Stabellini wrote: Adding Bertrand, Oleksandr, Julien, and others -- they have a more recent experience with GICv3 ITS than me and might be able to help. I am attaching the device tree Leo sent a few days ago for reference. Typically when you can set the ethernet link up and no packets are exchanged it is because of a missing interrupt. In this case a missing MSI. Bertrand, I believe you tried the GIC ITS driver with PCI devices recently. It is expected to work correctly with MSIs in Dom0, right? OSSTest has some hardware (e.g. Thunder-X) where ITS is required to boot Dom0. I haven't seen any failure on recent Xen. We are testing 4.11 and onwards on Thunder-X. However, it may be possible that some more work is necessary for other hardware (e.g. workaround, missing code...). See more below. On Tue, 17 Nov 2020, Leo Krueger wrote: I couldn't find this compatible defined/used in Linux 5.10-rc4. @Leo, could you clarify which flavor/version of Linux you are using?
This message is normal. Xen on Arm is not yet aware of PCI devices and therefore the hypercalls to add PCI devices will return -EOPNOTSUPP. However, this is not an issue because the virtual ITS implementation will allow dom0 to configure any devices. But (!) I cannot receive or transmit anything (no error message...) and there seem to be no interrupts: 29: 0 ITS-MSI 1 Edge gbe0-rxtx0 32: 0 ITS-MSI 8192 Edge ptp_qoriq (from /proc/interrupts). Any idea on this one? I keep digging and checking whether my device tree needs some additional fixes. Can you apply patch [1] and provide the logs? This will dump more information about the command received by the vITS and the one send to the host ITS. Note that Xen will need to be build with CONFIG_DEBUG=y in order to get some of the messages. [...] VLPI is a feature that was introduced in GICv4 to directly inject LPI in the guest. So this is normal to see this message when running on Xen because we are going to only expose a GICv3 to a domain until at least we support nested virt.[ 0.000000] GICv3: Distributor has no Range Selector support [ 0.000000] GICv3: no VLPI support, no direct LPI support [ 0.000000] GICv3: CPU0: found redistributor 0 region 0:0x0000000006040000"no VLPI support" is very suspicious, it looks like Dom0 doesn't find any ITS support. However, you were right about that Xen didn't expose the ITS because the following lines were missing: [ 0.000000] ITS@0x0000000006020000: allocated 65536 Devices @dc880000 (flat, esz 8, psz 64K, shr 1) Cheers, [1] diff --git a/xen/arch/arm/gic-v3-its.c b/xen/arch/arm/gic-v3-its.c index 9558bad96ac3..8a0a02308e74 100644 --- a/xen/arch/arm/gic-v3-its.c +++ b/xen/arch/arm/gic-v3-its.c@@ -87,6 +87,10 @@ static int its_send_command(struct host_its *hw_its, const void *its_cmd)
/* No ITS commands from an interrupt handler (at the moment). */
ASSERT(!in_irq());
+ printk(XENLOG_WARNING, "pITS cmd 0x%02lx: %016lx %016lx %016lx
%016lx\n",
+ its_cmd_get_command(command),
+ command[0], command[1], command[2], command[3]);
+
spin_lock(&hw_its->cmd_lock);
do {
diff --git a/xen/arch/arm/gic-v3-lpi.c b/xen/arch/arm/gic-v3-lpi.c
index 869bc97fa1aa..e7c5bcd8d423 100644
--- a/xen/arch/arm/gic-v3-lpi.c
+++ b/xen/arch/arm/gic-v3-lpi.c
@@ -183,7 +183,10 @@ void gicv3_do_LPI(unsigned int lpi)
/* Find out if a guest mapped something to this physical LPI. */
hlpip = gic_get_host_lpi(lpi);
if ( !hlpip )
+ {
+ printk("%s: Received LPI %u but it is not mapped?\n", __func__,
lpi);
goto out;
+ }
hlpi.data = read_u64_atomic(&hlpip->data);
@@ -222,6 +225,9 @@ void gicv3_lpi_update_host_entry(uint32_t host_lpi,
int domain_id,
{
union host_lpi *hlpip, hlpi;
+ printk("%s: host_lpi %u domain %d virq_lpi %u\n",
+ __func__, host_lpi, domain_id, virq_lpi);
+
ASSERT(host_lpi >= LPI_OFFSET);
host_lpi -= LPI_OFFSET;
diff --git a/xen/arch/arm/vgic-v3-its.c b/xen/arch/arm/vgic-v3-its.c
index 58d939b85f92..89ef137b3e6b 100644
--- a/xen/arch/arm/vgic-v3-its.c
+++ b/xen/arch/arm/vgic-v3-its.c
@@ -897,7 +897,7 @@ out_unlock:
static void dump_its_command(uint64_t *command)
{
- gdprintk(XENLOG_WARNING, " cmd 0x%02lx: %016lx %016lx %016lx
%016lx\n",
+ gdprintk(XENLOG_WARNING, "vITS cmd 0x%02lx: %016lx %016lx %016lx
%016lx\n",
its_cmd_get_command(command),
command[0], command[1], command[2], command[3]);
}
@@ -926,6 +926,8 @@ static int vgic_its_handle_cmds(struct domain *d,
struct virt_its *its)
if ( ret )
return ret;
+ dump_its_command(command);
+
switch ( its_cmd_get_command(command) )
{
case GITS_CMD_CLEAR:
--
Julien Grall
|
 |
Lists.xenproject.org is hosted with RackSpace, monitoring our |