[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] libxenstat: avoid build race
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Wed, 18 Nov 2020 14:27:52 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Eoa5f+8TE4fAfZ8cqc7+v3IXwmgM2gUOr40kRT67MSE=; b=AXs4vLL8kkeYzjzqOESvbJvFhBrfBCegZyllwQoM2eJFSpfAi49Z2Q9yNWTfh0OYccUiX+099NNPZXgA3c2R0CjQeTJspT+G3gAZOF242YHl4TJaKJQiOMEZwLS3crAR6xsU53lvjU7VKTJQkkjscdRNaHDlbl7GIKr3EZ8EOqTsFgRMsYdZTTEVCTTzK+eLDj/LeB7W8QjMt0kFURuULND8W1msw2QUgqkxTDVKg5Wpsxzz+OgS2bZljaMoC5VNmnhzdVhZsdWa4kJcjS6f2jq9ppqkgW/EO+CBy+2pN15+XsQROtBFedHSIfkYp7XV8CHVOCHMcsqDbBZiBG8DAQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IhrNqNa9ts72/BfQrcfGfXk52PiRk88ojUk7FBNlO4iZn1XChWRW2CkqE5CNWbGuWRg650ZhybDOhbPs7QO+a4JPYHqBFFrYYYFmORTfcBkNKb2TvBE1jgZgRhw6r4hz/fpIroYr/w1BQ+a+R2H16EGtAzzU5UlkeUGrwoAXpQLeuHSpH1MWOnTkcwJ7+7aSRZoP+VrbuGIKo6lyCyCu+mDD7HuGs5ELiYy2D2FBNWkyyQvwILis85HqlfGRtdM3dDm5p8kDAcUMcaWZDlpthrJ53iO6GC/AoCqY3UwNnjF9PwBTduTqvHdCg2bTzbc59dxtH77J7CvxB+4vjvqK6A==
- Authentication-results-original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Olaf Hering <olaf@xxxxxxxxx>
- Delivery-date: Wed, 18 Nov 2020 14:28:07 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHWvMYUgIctYS6LB0S1NxEfdujSB6nN9HIA
- Thread-topic: [PATCH] libxenstat: avoid build race
Hi,
> On 17 Nov 2020, at 09:42, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> Olaf reported observing
>
> xenstat_qmp.c:26:10: fatal error: _paths.h: No such file or directory
> .../tools/libs/stat/../../../tools/Rules.mk:153: xenstat_qmp.opic] Error 1
>
> Obviously _paths.h, when included by any of the sources, needs to be
> created in advance of compiling any of them, not just the non-PIC ones.
>
> Reported-by: Olaf Hering <olaf@xxxxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
> ---
> A similar issue (at the time of the report) in the building of
> libxenstore was addressed by Jürgen's 9af5e2b31b4e ("tools/libs/store:
> don't use symbolic links for external files").
>
> --- a/tools/libs/stat/Makefile
> +++ b/tools/libs/stat/Makefile
> @@ -30,7 +30,7 @@ include $(XEN_ROOT)/tools/libs/libs.mk
>
> include $(XEN_ROOT)/tools/libs/libs.mk
>
> -$(LIB_OBJS): _paths.h
> +$(LIB_OBJS) $(PIC_OBJS): _paths.h
>
> PYLIB=bindings/swig/python/_xenstat.so
> PYMOD=bindings/swig/python/xenstat.py
>
|
