[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 3/3] xen/arm: acpi: Allow Xen to boot with ACPI 5.1
- To: Julien Grall <julien@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Thu, 19 Nov 2020 18:16:31 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1gDaQBXj71zio6oakGrC5v+bim1fumny6+u3JxWrjeI=; b=DqMSdc4tbjwh7owLg454pfao96Gukt+Hj0pd4JueZwZVEHmH+k/Oc6w0MbndW7xkVr7z80OHVaAAbEPXZe30NOLXbhI8pAwssXzKQStRaDy0sw+s7eiHR3yuNTK9v6PHTM8bZHyW+suk5BdxNGBPMEwFXsftfIWnRXfXPqk5Nt1cKC90ohaGLaxLTOhsJF4WL/0CeCrJR1FkdotdzgPek/Cj/t4hSEBbmkPkCVEih1KlgZAxeJlLxykHP8IH4j1rjhpW6+GD2SOp6ydcta8ZdTtmLdxI/YwIyECCstrQQ7/X5QcBdeVJkILFVd0cRHNdja3An4ClH3sG3AeaI1VUDg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zoo1P756vqIA4oNYx4B04EBBJ3LjLVjVxnwlsXKUP7KcVCSv2VVuXGX9elHMySE7NHMZowgoLdgIFKotghYBla2BfHkTc5drZcdOnsTIKCm2Nhci/rwfxxp4TqTC4ppvduydYUQBXaRzcCerIBKQqsQMzESZyYk6weIrYNzqw2K8Pt3QIHf08mSmz3liVUOlCvX0bF2XYUM3WjJwxWhacN6UWg26BnJ2+0LRoWHkEfayTTh4j4AGnc7pm1UxWPxNn5P0TohLn5W/OnPycj+GGf9ePDp0Pmjssv+mdg/1UJZ5vNU7iKFUMfP0teFPBFLNiqPslhI/qwTMoi1GT7V0KA==
- Authentication-results-original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Cc: "open list:X86" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "alex.bennee@xxxxxxxxxx" <alex.bennee@xxxxxxxxxx>, Andre Przywara <Andre.Przywara@xxxxxxx>, Rahul Singh <Rahul.Singh@xxxxxxx>, Julien Grall <Julien.Grall@xxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Thu, 19 Nov 2020 18:16:49 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHWvpapKLofsEj7tESNWS0wcJnqO6nPwwiA
- Thread-topic: [PATCH v4 3/3] xen/arm: acpi: Allow Xen to boot with ACPI 5.1
Hi,
> On 19 Nov 2020, at 17:08, Julien Grall <julien@xxxxxxx> wrote:
>
> From: Julien Grall <julien.grall@xxxxxxx>
>
> At the moment Xen requires the FADT ACPI table to be at least version
> 6.0, apparently because of some reliance on other ACPI v6.0 features.
>
> But actually this is overzealous, and Xen works now fine with ACPI v5.1.
>
> Let's relax the version check for the FADT table to allow QEMU to
> run the hypervisor with ACPI.
>
> Signed-off-by: Julien Grall <julien.grall@xxxxxxx>
> Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx>
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
> Acked-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
>
> ---
> Changes in v3:
> - Add Stefano's acked-by
>
> Changes in v2:
> - Patch added
> ---
> xen/arch/arm/acpi/boot.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/xen/arch/arm/acpi/boot.c b/xen/arch/arm/acpi/boot.c
> index 55c3e5cbc834..7ea2990cb82c 100644
> --- a/xen/arch/arm/acpi/boot.c
> +++ b/xen/arch/arm/acpi/boot.c
> @@ -181,8 +181,8 @@ static int __init acpi_parse_fadt(struct
> acpi_table_header *table)
> * we only deal with ACPI 6.0 or newer revision to get GIC and SMP
> * boot protocol configuration data, or we will disable ACPI.
> */
> - if ( table->revision > 6
> - || (table->revision == 6 && fadt->minor_revision >= 0) )
> + if ( table->revision > 5
> + || (table->revision == 5 && fadt->minor_revision >= 1) )
> return 0;
>
> printk("Unsupported FADT revision %d.%d, should be 6.0+, will disable
> ACPI\n",
> --
> 2.17.1
>
|
