[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 69/78] block: remove the nr_sects field in struct hd_struct



On 11/16/20 3:58 PM, Christoph Hellwig wrote:
Now that the hd_struct always has a block device attached to it, there is
no need for having two size field that just get out of sync.

Additional the field in hd_struct did not use proper serializiation,
possibly allowing for torn writes.  By only using the block_device field
this problem also gets fixed.

Signed-off-by: Christoph Hellwig <hch@xxxxxx>
---
  block/bio.c                        |  2 +-
  block/blk-core.c                   |  2 +-
  block/blk.h                        | 53 ----------------------
  block/genhd.c                      | 34 +++++++-------
  block/partitions/core.c            | 17 ++++---
  drivers/block/loop.c               |  1 -
  drivers/block/nbd.c                |  2 +-
  drivers/block/xen-blkback/common.h |  4 +-
  drivers/md/bcache/super.c          |  2 +-
  drivers/s390/block/dasd_ioctl.c    |  4 +-
  drivers/target/target_core_pscsi.c |  7 +--
  fs/block_dev.c                     | 73 +-----------------------------
  fs/f2fs/super.c                    |  2 +-
  fs/pstore/blk.c                    |  2 +-
  include/linux/genhd.h              | 29 +++---------
  kernel/trace/blktrace.c            |  2 +-
  16 files changed, 47 insertions(+), 189 deletions(-)

Reviewed-by: Hannes Reinecke <hare@xxxxxxx>

Cheers,

Hannes
--
Dr. Hannes Reinecke                Kernel Storage Architect
hare@xxxxxxx                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.