Re: [PATCH v2 05/12] viridian: use hypercall_vpmask in hvcall_ipi()

[Jan Beulich <jbeulich@xxxxxxxx>]

On 20.11.2020 10:48, Paul Durrant wrote:
> --- a/xen/arch/x86/hvm/viridian/viridian.c
> +++ b/xen/arch/x86/hvm/viridian/viridian.c
> @@ -551,6 +551,25 @@ static bool vpmask_test(const struct hypercall_vpmask 
> *vpmask,
>      return test_bit(vp, vpmask->mask);
>  }
>  
> +static unsigned int vpmask_first(struct hypercall_vpmask *vpmask)

Now this and ...

> +{
> +    return find_first_bit(vpmask->mask, HVM_MAX_VCPUS);
> +}
> +
> +static unsigned int vpmask_next(struct hypercall_vpmask *vpmask, unsigned 
> int vp)

... this should really have pointers to const as parameters.

> @@ -631,13 +650,21 @@ static int hvcall_flush(union hypercall_input *input,
>      return 0;
>  }
>  
> +static void send_ipi(struct hypercall_vpmask *vpmask, uint8_t vector)

And I guess this one should, too.

Jan