[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/3] ns16550: drop stray "#ifdef CONFIG_HAS_PCI"
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Rahul Singh <Rahul.Singh@xxxxxxx>
- Date: Tue, 24 Nov 2020 09:52:08 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OYMspa/OlGi/l4ukMEcDAxi0KoqVji6ybi+Ak4X8Tuo=; b=MwXHtgIzhxsOjUZt1FQ4NQAUR+a9vFyNLA8fa2pS2vdurL0ZBSxqgJJmk6KiZt1pLCDGgs+98uuKBvjjk/euKOvfshaOdCV2pR+cd4hXJ6NbFQ+5JUiqfqdnOj9BRjxOP/mXwra3kyr3p0hVV+wOnPndz7+Fradt9NtpSQjwuGw2HpG/FVJOSvnTKvwR9xL/KU3E9bSOEtUqhvnX5KRFfdIaUvt4zRwg2Lz0Byw4DQ0xN1lb111na9U965h3+sgH7oLN0hquid9zMnhPBCKcq3ITgz4XKQ8ZC1XD+3NydgXCV/rfHPoco1SJgRI4B4VSMX9/2zSVKnlXknh51PCgpA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SJEzzh+CIlMUSUZRVM1pjRBp5aEvBjMBBHnsnnSoIGhyTfNdJJ/vi2caJn0nypzV9eA771ZWyi72jfjL3H19I1okiVfjqj9uhXviNn2xravYPDN2CGxS7S/k7atpp6CjrpbJL/MwHB8xyKmv1bYpsjbkXh+NJGstJBP5sHT/GZJoR8pg/PM28vwJkwMbt1K8U43RNXyGupjIgbC2ohd4afQg/6w6BLAc/6t2pZfuLtjKsIdjrymPD0YG2goqslEAIIohx0QGiWffRhIF0zrENQy1xNvyzFuea/fwPaoc4kun8RDgyolZbF3F/zemoPnxU7D7MPyxflEEqOF0hj299w==
- Authentication-results-original: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Tue, 24 Nov 2020 09:52:22 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHWwZq/qJpu10nDFkuzrG8rOtqGVanWaYOAgACiOQA=
- Thread-topic: [PATCH v2 3/3] ns16550: drop stray "#ifdef CONFIG_HAS_PCI"
Hello ,
> On 24 Nov 2020, at 12:11 am, Stefano Stabellini <sstabellini@xxxxxxxxxx>
> wrote:
>
> On Mon, 23 Nov 2020, Jan Beulich wrote:
>> There's no point wrapping the function invocation when
>> - the function body is already suitably wrapped,
>> - the function itself is unconditionally available.
>>
>> Reported-by: Julien Grall <julien@xxxxxxx>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>
Reviewed-by: Rahul Singh <rahul.singh@xxxxxxx>
>
>> --- a/xen/drivers/char/ns16550.c
>> +++ b/xen/drivers/char/ns16550.c
>> @@ -662,9 +662,7 @@ static int __init check_existence(struct
>> return 1; /* Everything is MMIO */
>> #endif
>>
>> -#ifdef CONFIG_HAS_PCI
>> pci_serial_early_init(uart);
>> -#endif
>>
>> /*
>> * Do a simple existence test first; if we fail this,
>>
>
Regards,
Rahul
|
