[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH RFC 2/6] xen/arm: mm: Remove ; at the end of mm_printk()
- To: Julien Grall <julien@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Tue, 24 Nov 2020 12:19:40 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9lPurmAyxjBr8vvqzQC466c9CBWgu4SVW3fNteI5ru4=; b=gpd0zQ3kb/DYKEKZS9LlKTQDlhDFLp1E5UPXD5JbclZsQueORuPB6wVpKC7zziQK4GMC+rN/PKPL8b2RitpR6mFJZnJbfPz8XcYT2W+N9l4ImkAb71cusPZkFi1qDJMXzU/HZ24jyEUwQewBDUkR8ackhLmZ5kkMYhCWjDrhaB85q+OOJT37rC1TLS9s8zXaDidrpjN+xvFw8OAODqBusvxqtbSjCNNubDiKQgq3nKLNg7UcDlbwv4u89pktrSpSZ4lMnOll8h4HhQk5aqml7uFdwCKJislGgvUaZpgRNsZvzE9X0WKvXEYTPUCSNfDAdArrvaBBFHk8mjSNs4nZQw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MAgOW6gzhDn+wMwnQmLZkCBGRbp4MDuGIPy69Vkojjmzv30NRqNIsgEJcb5dI7Amhq4/1CyYUQR0pvFCPOnel8i/gi4heOMgrkL16W5Nmq0wGOSsJJP0bHiKdzMgWhuTAq5Miki36jprWknBU+0GujYM+YAMjJv/7zyDoYP/IAEeFn2/Dd6GjSqPKlmrShtFE4oHQwx0WYgm8RSlM+e/vKybAwV8v4NWWNNMy3eSa7FtYXYBqrKKq979ExOD/xNcNQY4o+hyIRhO0Ktsg1dpOwWKHv648x1maS4fiuWPxviQPiERkz2ZLhYW4eAqzENHMlqg7vBIEg9j2kEcDWdZJg==
- Authentication-results-original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Cc: "open list:X86" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 24 Nov 2020 12:20:02 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHWvqdY1rahTHlLkUqbsCGy2n+E1qnXOtqA
- Thread-topic: [PATCH RFC 2/6] xen/arm: mm: Remove ; at the end of mm_printk()
Hi Julien,
> On 19 Nov 2020, at 19:07, Julien Grall <julien@xxxxxxx> wrote:
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> The ; at the end of mm_printk() means the following code will not build
> correctly:
>
> if ( ... )
> mm_printk(...);
> else
> ...
>
> As we treat the macro as a function, we want to remove the ; at the end
> of it.
>
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
> ---
> xen/arch/arm/mm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
> index 4dd886f7c80d..59f8a3f15fd1 100644
> --- a/xen/arch/arm/mm.c
> +++ b/xen/arch/arm/mm.c
> @@ -59,7 +59,7 @@ mm_printk(const char *fmt, ...) {}
> { \
> dprintk(XENLOG_ERR, fmt, ## args); \
> WARN(); \
> - } while (0);
> + } while (0)
> #endif
>
> /*
> --
> 2.17.1
>
>
|
