Re: [PATCH 13/45] block: add a bdev_kobj helper

[Coly Li <colyli@xxxxxxx>]

On 11/24/20 9:27 PM, Christoph Hellwig wrote:
> Add a little helper to find the kobject for a struct block_device.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Reviewed-by: Jan Kara <jack@xxxxxxx>
> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@xxxxxxx>

For the bcache part, Acked-by: Coly Li <colyli@xxxxxxx>

Thanks.

Coly Li

> ---
>  drivers/md/bcache/super.c |  7 ++-----
>  drivers/md/md.c           |  4 +---
>  fs/block_dev.c            |  6 +++---
>  fs/btrfs/sysfs.c          | 15 +++------------
>  include/linux/blk_types.h |  3 +++
>  5 files changed, 12 insertions(+), 23 deletions(-)
> 
> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
> index 46a00134a36ae1..a6a5e21e4fd136 100644
> --- a/drivers/md/bcache/super.c
> +++ b/drivers/md/bcache/super.c
> @@ -1447,8 +1447,7 @@ static int register_bdev(struct cache_sb *sb, struct 
> cache_sb_disk *sb_disk,
>               goto err;
>  
>       err = "error creating kobject";
> -     if (kobject_add(&dc->disk.kobj, &part_to_dev(bdev->bd_part)->kobj,
> -                     "bcache"))
> +     if (kobject_add(&dc->disk.kobj, bdev_kobj(bdev), "bcache"))
>               goto err;
>       if (bch_cache_accounting_add_kobjs(&dc->accounting, &dc->disk.kobj))
>               goto err;
> @@ -2342,9 +2341,7 @@ static int register_cache(struct cache_sb *sb, struct 
> cache_sb_disk *sb_disk,
>               goto err;
>       }
>  
> -     if (kobject_add(&ca->kobj,
> -                     &part_to_dev(bdev->bd_part)->kobj,
> -                     "bcache")) {
> +     if (kobject_add(&ca->kobj, bdev_kobj(bdev), "bcache")) {
>               err = "error calling kobject_add";
>               ret = -ENOMEM;
>               goto out;

[snipped]