Re: [PATCH 12/45] block: remove a superflous check in blkpg_do_ioctl

[Jan Kara <jack@xxxxxxx>]

On Tue 24-11-20 14:27:18, Christoph Hellwig wrote:
> sector_t is now always a u64, so this check is not needed.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good. You can add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

                                                                Honza

> ---
>  block/ioctl.c | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/block/ioctl.c b/block/ioctl.c
> index 6b785181344fe1..0c09bb7a6ff35f 100644
> --- a/block/ioctl.c
> +++ b/block/ioctl.c
> @@ -35,15 +35,6 @@ static int blkpg_do_ioctl(struct block_device *bdev,
>       start = p.start >> SECTOR_SHIFT;
>       length = p.length >> SECTOR_SHIFT;
>  
> -     /* check for fit in a hd_struct */
> -     if (sizeof(sector_t) < sizeof(long long)) {
> -             long pstart = start, plength = length;
> -
> -             if (pstart != start || plength != length || pstart < 0 ||
> -                 plength < 0 || p.pno > 65535)
> -                     return -EINVAL;
> -     }
> -
>       switch (op) {
>       case BLKPG_ADD_PARTITION:
>               /* check if partition is aligned to blocksize */
> -- 
> 2.29.2
> 
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR