Xen project Mailing List

Re: [PATCH] tools/libs: Simplify internal *.pc files

To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>

Date: Wed, 25 Nov 2020 15:46:02 +0000

Accept-language: en-GB, en-US

Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none

Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vZCq383xp/5qy+M97nZfOlE0VcTD2KOnamzXXXUAHsI=; b=SRF8pYVW8tFPA90MJhTkLH9PV2MI9tc9LDl1pXtSCwatTQkDY9yLxXnMrXJQ89AABmlGw7e/hsjB7ODfLVPJZwnv6s2qS+/Ul27C9rC90zqxkZbzFFvDA2H7thqt/Ffz8Qkyo8CG5UvZt93yI78U9Sls87vMGPA/W9cQM63yj114O0mwglYLNcGwHyh2j13mFVdGWT5PjQKwOBHkLEvnK8m57AjvwWHFzasO/mntneYhR6PqQDG8FEg1WIRFqB0w4ByzbkyQsRRGH6M1Vclk5eXCxfP9spW8W6BKlPSfZ8WSBt9PKsFz6bkkrZE6Qmq+lVmAODr4s3nHbo8m5BbGIA==

Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iMd/Wm90SaMsJdmKe/WRyd/h3CGvfy6swOAX8M4stUEOGy0+hx9Y8QAahExR6pkKEl2iiH0iW5M/IvLWzkTdtxyeOEC1SBjbPHFzlY0OVnFawCbCOrojl+9CCRtJw2B159DcSlb1Wp2CA0h8Fw4+qQmK486f1kcTJ+OJBuJOtlvnrek6oRVxuQnZ90sGNQ4jpSja47J6NA6DD1IKRm5yTAwZEZpnhXJOsuY3cgEMk4IzGStULGExjRwuqacLEUxCefaw+3DKdDv9hKGJY1uv5iwUB6sMHhHoEujZbjBB25ms5Z6Tn+/Y7utiWHVOhA4QHKABuATa1sbjBmhUsFX5eg==

Authentication-results-original: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;

Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>

Delivery-date: Wed, 25 Nov 2020 15:46:22 +0000

List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Nodisclaimer: true

Original-authentication-results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=arm.com;

Thread-index: AQHWwzpU13+Sxy8T80ynkBYhTAz0lKnY/bGA

Thread-topic: [PATCH] tools/libs: Simplify internal *.pc files

Hi Andrew, > On 25 Nov 2020, at 14:49, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote: > > The internal package config file for libxenlight reads (reformatted to avoid > exceeding the SMTP 998-character line length): > > Libs: -L${libdir} > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toollog > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toollog > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toolcore > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/evtchn > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toolcore > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toollog > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toollog > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toolcore > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/call > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toollog > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toolcore > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/evtchn > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toollog > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toolcore > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/gnttab > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toollog > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toolcore > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/foreignmemory > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toollog > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toolcore > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toollog > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toolcore > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/call > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/devicemodel > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/ctrl > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toolcore > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/store > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toollog > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toolcore > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toollog > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toolcore > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/call > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/hypfs > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toollog > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toolcore > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/evtchn > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toollog > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toollog > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toolcore > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/call > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toollog > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toolcore > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/evtchn > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toollog > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toolcore > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/gnttab > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toollog > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toolcore > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/foreignmemory > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toollog > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toolcore > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toollog > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toolcore > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/call > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/devicemodel > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/ctrl > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/guest > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/light > -lxenlight > > Drop duplicate -rpath-link='s to turn it into the slightly-more-manageable: > > Libs: -L${libdir} > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/call > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/ctrl > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/devicemodel > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/evtchn > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/foreignmemory > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/gnttab > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/guest > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/hypfs > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/light > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/store > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toolcore > > -Wl,-rpath-link=/local/security/xen.git/tools/libs/light/../../../tools/libs/toollog > -lxenlight > > Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx> Nice reduction of the output :-) Cheers Bertrand > --- > CC: Ian Jackson <iwj@xxxxxxxxxxxxxx> > CC: Wei Liu <wl@xxxxxxx> > CC: Juergen Gross <jgross@xxxxxxxx> > --- > tools/Rules.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/Rules.mk b/tools/Rules.mk > index f61da81f4a..5d92ff0699 100644 > --- a/tools/Rules.mk > +++ b/tools/Rules.mk > @@ -184,7 +184,7 @@ $(PKG_CONFIG_DIR)/%.pc: Makefile > $(XEN_ROOT)/tools/Rules.mk $(PKG_CONFIG_DIR) > echo "Description: $(PKG_CONFIG_DESC)"; \ > echo "Version: $(PKG_CONFIG_VERSION)"; \ > echo "Cflags: -I\$${includedir} $(CFLAGS_xeninclude)"; \ > - echo "Libs: -L\$${libdir} $(PKG_CONFIG_USELIBS) -l$(PKG_CONFIG_LIB)"; \ > + echo "Libs: -L\$${libdir} $(sort $(PKG_CONFIG_USELIBS)) > -l$(PKG_CONFIG_LIB)"; \ > echo "Libs.private: $(PKG_CONFIG_LIBSPRIV)"; \ > echo "Requires.private: $(PKG_CONFIG_REQPRIV)"; \ > } > $@ > -- > 2.11.0 > >

©2013 Xen Project, A Linux Foundation Collaborative Project. All Rights Reserved.
Linux Foundation is a registered trademark of The Linux Foundation.
Xen Project is a trademark of The Linux Foundation.