[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Intel-wired-lan] [PATCH 000/141] Fix fall-through warnings for Clang
- To: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>
- From: Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx>
- Date: Thu, 26 Nov 2020 08:33:24 +1100 (AEDT)
- Cc: James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, "Gustavo A. R. Silva" <gustavoars@xxxxxxxxxx>, Joe Perches <joe@xxxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, alsa-devel@xxxxxxxxxxxxxxxx, linux-atm-general@xxxxxxxxxxxxxxxxxxxxx, reiserfs-devel@xxxxxxxxxxxxxxx, linux-iio@xxxxxxxxxxxxxxx, linux-wireless <linux-wireless@xxxxxxxxxxxxxxx>, linux-fbdev@xxxxxxxxxxxxxxx, dri-devel <dri-devel@xxxxxxxxxxxxxxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, Nathan Chancellor <natechancellor@xxxxxxxxx>, linux-ide@xxxxxxxxxxxxxxx, dm-devel@xxxxxxxxxx, keyrings@xxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, GR-everest-linux-l2@xxxxxxxxxxx, wcn36xx@xxxxxxxxxxxxxxxxxxx, samba-technical@xxxxxxxxxxxxxxx, linux-i3c@xxxxxxxxxxxxxxxxxxx, linux1394-devel@xxxxxxxxxxxxxxxxxxxxx, linux-afs@xxxxxxxxxxxxxxxxxxx, usb-storage@xxxxxxxxxxxxxxxxxxxxxxxx, drbd-dev@xxxxxxxxxxxxxxxx, devel@xxxxxxxxxxxxxxxxxxxx, linux-cifs@xxxxxxxxxxxxxxx, rds-devel@xxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, linux-rdma@xxxxxxxxxxxxxxx, oss-drivers@xxxxxxxxxxxxx, bridge@xxxxxxxxxxxxxxxxxxxxxxxxxx, linux-security-module@xxxxxxxxxxxxxxx, amd-gfx list <amd-gfx@xxxxxxxxxxxxxxxxxxxxx>, linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx, cluster-devel@xxxxxxxxxx, linux-acpi@xxxxxxxxxxxxxxx, coreteam@xxxxxxxxxxxxx, intel-wired-lan@xxxxxxxxxxxxxxxx, linux-input@xxxxxxxxxxxxxxx, Miguel Ojeda <ojeda@xxxxxxxxxx>, tipc-discussion@xxxxxxxxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-media@xxxxxxxxxxxxxxx, linux-watchdog@xxxxxxxxxxxxxxx, selinux@xxxxxxxxxxxxxxx, linux-arm-msm <linux-arm-msm@xxxxxxxxxxxxxxx>, intel-gfx@xxxxxxxxxxxxxxxxxxxxx, linux-geode@xxxxxxxxxxxxxxxxxxx, linux-can@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-gpio@xxxxxxxxxxxxxxx, op-tee@xxxxxxxxxxxxxxxxxxxxxxxxx, linux-mediatek@xxxxxxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, nouveau@xxxxxxxxxxxxxxxxxxxxx, linux-hams@xxxxxxxxxxxxxxx, ceph-devel@xxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, Linux ARM <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, linux-hwmon@xxxxxxxxxxxxxxx, "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@xxxxxxxxxx>, linux-nfs@xxxxxxxxxxxxxxx, GR-Linux-NIC-Dev@xxxxxxxxxxx, Linux Memory Management List <linux-mm@xxxxxxxxx>, Network Development <netdev@xxxxxxxxxxxxxxx>, linux-decnet-user@xxxxxxxxxxxxxxxxxxxxx, linux-mmc@xxxxxxxxxxxxxxx, Linux-Renesas <linux-renesas-soc@xxxxxxxxxxxxxxx>, linux-sctp@xxxxxxxxxxxxxxx, linux-usb@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" <linux-crypto@xxxxxxxxxxxxxxx>, patches@xxxxxxxxxxxxxxxxxxxxx, linux-integrity@xxxxxxxxxxxxxxx, target-devel@xxxxxxxxxxxxxxx, linux-hardening@xxxxxxxxxxxxxxx, Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 25 Nov 2020 21:33:35 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, 25 Nov 2020, Nick Desaulniers wrote:
> So developers and distributions using Clang can't have
> -Wimplicit-fallthrough enabled because GCC is less strict (which has
> been shown in this thread to lead to bugs)? We'd like to have nice
> things too, you know.
>
Apparently the GCC developers don't want you to have "nice things" either.
Do you think that the kernel should drop gcc in favour of clang?
Or do you think that a codebase can somehow satisfy multiple checkers and
their divergent interpretations of the language spec?
> This is not a shiny new warning; it's already on for GCC and has existed
> in both compilers for multiple releases.
>
Perhaps you're referring to the compiler feature that lead to the
ill-fated, tree-wide /* fallthrough */ patch series.
When the ink dries on the C23 language spec and the implementations figure
out how to interpret it then sure, enforce the warning for new code -- the
cost/benefit analysis is straight forward. However, the case for patching
existing mature code is another story.
|