Re: [PATCH] xen/irq: Propagate the error from init_one_desc_irq() in init_irq_data()

[Julien Grall <julien@xxxxxxx>]

On 19/11/2020 23:44, Stefano Stabellini wrote:
> On Thu, 19 Nov 2020, Julien Grall wrote:
> > From: Julien Grall <jgrall@xxxxxxxxxx>
> >
> > init_one_desc_irq() can return an error if it is unable to allocate
> > memory. While this is unlikely to happen during boot (called from
> > init_irq_data()), it is better to harden the code by propagting the
> > return value.
> >
> > Spotted by coverity.
> >
> > CID: 106529
> >
> > Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
> Hi Julien,
Hi Stefano,

> Thanks for the patch. I was about to commit it when I realized there is
> one more caller: xen/arch/arm/irq.c:init_local_irq_data
>
> Should we change that too to check for the return error?
We should change too. I will send a new version.

Cheers,

--
Julien Grall